Conversation
There was a problem hiding this comment.
Code Review
This pull request adds region tags around the google-cloud-policy-troubleshooter dependency in iam/api-client/pom.xml. The reviewer suggested updating the region tag name to include the iam_ prefix to align with the planned naming convention.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds region tags (iam_policytroubleshooter_java_dependency) around the existing google-cloud-policy-troubleshooter dependency in iam/api-client/pom.xml. There are no review comments to address, and I have no additional feedback to provide.
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
Description
Fixes b/385748009
This PR is the First part of the two PR process to rename the previous region tag, so it doesn't break the current devsite documentation. (Add new region tag -> Update devsite documentation -> New PR deleting old region tag)
The
troubleshooter_java_dependencyregion tag belongs to the primary product of Policy Troubleshooter (part of Policy Intelligence).The main reference to this region tag appears on the Google Cloud documentation at https://docs.cloud.google.com/policy-intelligence/docs/reference/libraries. It is documented under the Policy Troubleshooter API, which in all of the REST reference includes the
.iamreference. Furthermore, in thegoogle-cloud-javarepository, it references the Policy Troubleshooter API to the IAM product (https://github.com/googleapis/google-cloud-java/tree/main/java-policy-troubleshooter) using the same dependency referenced on the main and first Google doc here.Based on this, and considering the closest relation and use with IAM, the new prefix and name will be as follow
Region Tag Update
troubleshooter_java_dependencyiam_policytroubleshooter_java_dependencyThis includes the IAM product and adds the complete reference of the library on the region tag.
Impacted Documentation & References
.iamnamespace)iam/api-client/pom.xmlChecklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only