Skip to content

correct typings for mongoose model#110

Open
sojharo wants to merge 1 commit into
GraphQLGuide:masterfrom
sojharo:mongoose_type_correction
Open

correct typings for mongoose model#110
sojharo wants to merge 1 commit into
GraphQLGuide:masterfrom
sojharo:mongoose_type_correction

Conversation

@sojharo

@sojharo sojharo commented Sep 27, 2022

Copy link
Copy Markdown

Types should not extend Document as per discussion in #88

@lorensr

lorensr commented Oct 8, 2022

Copy link
Copy Markdown
Member

Hey @sojharo, sorry for the delay, and thanks for the contribution! Did you test the types manually for both MongoDB Collections and Mongoose Models? If you feel like an automated test (just running tsc on an example ts file), that would be helpful ☺️

@sojharo

sojharo commented Oct 14, 2022

Copy link
Copy Markdown
Author

Hey, I had the library installed in my current project and went into node_modules folder to do the changes and then test with my current project. I was able to reproduce the issue and then solve it with these changes in index.d.ts which are in this PR. When I run the project, I compile it using sucrase-node library so it compiles the typescript to javascript.

@andrmaz

andrmaz commented Jan 3, 2023

Copy link
Copy Markdown

@lorensr Any progress on this PR ?

@sojharo

sojharo commented Mar 1, 2023

Copy link
Copy Markdown
Author

Hey, yes. I had tested them with tsc and also tested it with my project by doing these changes directly inside installed version inside node_modules folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants