Remove CKEditor instance on unmount#29
Open
R0nd wants to merge 4 commits into
Open
Conversation
Contributor
Author
|
Fixed an issue where new or changed event handlers wouldn't register on existing component. |
… the editor instance is created
|
Any update on this. Seeing this issue. |
Contributor
Author
|
@hafeezpk the PR has never been merged, you can try installing my fork from npm if you want to, the package name is r0nd_react-ckeditor-component |
|
R0nd i did try the package r0nd_react-ckeditor-component. Still seeing the same issue. |
Contributor
Author
|
@hafeezpk could you post some code? Doesn't reproduce with a trivial case. |
|
I'm just rendering multiple instances of CKEditor. Although the point to note is, manually on the web browser we never see this issue. Using karma (chrome) which automatically launches web browser for functional testing, we see the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems to fix the sometimes appearing "Uncaught TypeError: Cannot call method 'unselectable' of null" errors