refactor: deprecate dead code#2766
Open
JoLo90 wants to merge 1 commit into
Open
Conversation
JoLo90
force-pushed
the
fix_deprecate_dead_code
branch
2 times, most recently
from
87a8e84 to
15d9d60
Compare
JoLo90
force-pushed
the
fix_deprecate_dead_code
branch
from
15d9d60 to
aae7eb7
Compare
Member
|
@JoLo90 I think we should consider each of these removals before bundling them all into one PR. Can you open a few more issues to discuss other removals? |
Contributor
Author
RDaxini
reviewed
Jun 8, 2026
RDaxini
left a comment
RDaxini
left a comment
Member
There was a problem hiding this comment.
Added a suggestion to the whatsnew. I can do a a more technical review later.
Note for future PRs though @JoLo90, please only tick off checklist items when complete. For example, a maintainer has not added any relevant labels or milestone to this PR yet so this should not have been ticked. I will do it now (so no need to remove the tick now). This will just help us organize the work more efficiently and ensure we don't miss anything.
Thanks again for your continued contributions by the way, these are appreciated.
Comment on lines
+13
to
+21
| * The function :py:func:`pvlib.clearsky._is_leap_year` is deprecated and will be | ||
| removed in v0.17.0. Use :py:func:`pandas.Timestamp.is_leap_year` instead. | ||
| (:issue: `2764`, :pull:`2766`) | ||
| * The function :py:func:`pvlib.irradiance._liujordan` is deprecated and will be | ||
| removed in v0.17.0. (:issue: `2764`, :pull:`2766`) | ||
| * The function :py:func:`pvlib.modelchain.get_orientation` is deprecated and will | ||
| be removed in v0.17.0. (:issue: `2764`, :pull:`2766`) | ||
| * The method :py:meth:`pvlib.modelchain.ModelChain._prep_inputs_tracking` is | ||
| deprecated and will be removed in v0.17.0. (:issue: `2764`, :pull:`2766`) |
Member
There was a problem hiding this comment.
Let's clean this up and avoid unnecessary repetition:
Suggested change
| * The function :py:func:`pvlib.clearsky._is_leap_year` is deprecated and will be | |
| removed in v0.17.0. Use :py:func:`pandas.Timestamp.is_leap_year` instead. | |
| (:issue: `2764`, :pull:`2766`) | |
| * The function :py:func:`pvlib.irradiance._liujordan` is deprecated and will be | |
| removed in v0.17.0. (:issue: `2764`, :pull:`2766`) | |
| * The function :py:func:`pvlib.modelchain.get_orientation` is deprecated and will | |
| be removed in v0.17.0. (:issue: `2764`, :pull:`2766`) | |
| * The method :py:meth:`pvlib.modelchain.ModelChain._prep_inputs_tracking` is | |
| deprecated and will be removed in v0.17.0. (:issue: `2764`, :pull:`2766`) | |
| * The following functions have been deprecated and will be removed in v0.17.0: | |
| - :py:func:`pvlib.clearsky._is_leap_year` (use :py:func:`pandas.Timestamp.is_leap_year` instead) | |
| (:issue: `2764`, :pull:`2766`) | |
| - :py:func:`pvlib.irradiance._liujordan` (:issue: `2764`, :pull:`2766`) | |
| - :py:func:`pvlib.modelchain.get_orientation` (:issue: `2764`, :pull:`2766`) | |
| - :py:meth:`pvlib.modelchain.ModelChain._prep_inputs_tracking` (:issue: `2764`, :pull:`2766`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/referencefor API changes.docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.