Skip to content

counter_incs by incrementRows#89

Open
ummae wants to merge 7 commits into
python-happybase:masterfrom
ummae:master
Open

counter_incs by incrementRows#89
ummae wants to merge 7 commits into
python-happybase:masterfrom
ummae:master

Conversation

@ummae

@ummae ummae commented Apr 29, 2015

Copy link
Copy Markdown

related: #35

I am not sure that is proper way, but at least it works.

@landscape-bot

Copy link
Copy Markdown

Code Health
Repository health increased by 0.50% when pulling d455db0 on ummae:master into 6205177 on wbolster:master.

Comment thread happybase/table.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps counters_inc is a better name? And can you move it below counter_dec for clarity?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree and I will move it below counter_dec.

@wbolster

wbolster commented May 3, 2015

Copy link
Copy Markdown
Member

Hi, thanks for working on this. I've added a few questions/comments.

Any chance you can add some tests?

@ummae

ummae commented May 3, 2015

Copy link
Copy Markdown
Author

Sure, and I found some conventional problem on PEP8 styles(e.g. line break 79bytes, etc..).
I will re-PR after fixing it all.

ummae added 3 commits May 3, 2015 22:08
- Renaming method counter_incs to counters_inc
- Add nose tests for counters_inc
- Renaming method counter_incs to counters_inc
- Add nose tests for counters_inc
@landscape-bot

Copy link
Copy Markdown

Code Health
Repository health increased by 0.62% when pulling 209ce27 on ummae:master into 6205177 on wbolster:master.

@landscape-bot

Copy link
Copy Markdown

Code Health
Repository health increased by 0.67% when pulling c5761f6 on ummae:master into 6205177 on wbolster:master.

@ummae

ummae commented May 7, 2015

Copy link
Copy Markdown
Author

@wbolster Hi would you review this commit?

Comment thread tests/test_api.py

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, tests look good.

@wbolster

wbolster commented May 7, 2015

Copy link
Copy Markdown
Member

Thanks for working on this.

See comments about using a dict. Additionally, I think some mention of this in the user guide might make sense.

@landscape-bot

Copy link
Copy Markdown

Code Health
Repository health increased by 0.67% when pulling 3ab00d2 on ummae:master into 6205177 on wbolster:master.

@ummae

ummae commented May 7, 2015

Copy link
Copy Markdown
Author

I applied eventually ;)

@landscape-bot

Copy link
Copy Markdown

Code Health
Repository health increased by 0.67% when pulling ff5c525 on ummae:master into 6205177 on wbolster:master.

@ummae

ummae commented Jul 12, 2015

Copy link
Copy Markdown
Author

@wbolster Hi, I wonder do you mind to merge ;) and one question would you have plan happybase version2 for thrift2 protocol

@wbolster

Copy link
Copy Markdown
Member

Hi, #96 also adds support for batch counter increments using a different API. I think the API proposed in #96 is friendlier for applications. Thoughts?

@philip-sterne

Copy link
Copy Markdown

Hi @wbolster, I'm happy to add tests for #96 if you prefer the different API? We tried to keep the api identical to the Batch idea.

@RajatGoyal

Copy link
Copy Markdown

Any progress on this, It would be great If i can increase counters in bulk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants