Skip to content

fix mismatched dependency issues#182

Closed
mdynnl wants to merge 1 commit into
solidjs:legacyfrom
mdynnl:legacy
Closed

fix mismatched dependency issues#182
mdynnl wants to merge 1 commit into
solidjs:legacyfrom
mdynnl:legacy

Conversation

@mdynnl

@mdynnl mdynnl commented Aug 14, 2024

Copy link
Copy Markdown

By using ?external, this PR should solve most of the mismatched dependency issues caused by esm.sh's static build.

@mdynnl

mdynnl commented Aug 14, 2024

Copy link
Copy Markdown
Author

@milomg

milomg commented Aug 18, 2024

Copy link
Copy Markdown
Member

I would prefer if this were generic to all dependencies, but a brief glance at esm.sh doesn't reveal an easy way to do it automatically (I'd rather not just mark all keys as external for all packages because we'd get quadratic blowup and things would be less editable). Before I merge this, do you have any ideas that I should explore in that direction?

Update: Maybe https://jspm.org/docs/generator/stable/?

@mdynnl

mdynnl commented Aug 18, 2024

Copy link
Copy Markdown
Author

@mdynnl

mdynnl commented Aug 18, 2024

Copy link
Copy Markdown
Author

#183

It's still possible with esm.sh too, take this for example https://esm.sh/@solid-primitives/memo?external=@solid-primitives/memo,solid-js but we'll have to put every deps there so not really suitable.

@mdynnl

mdynnl commented Aug 26, 2024

Copy link
Copy Markdown
Author

closed in favor of #183

@mdynnl mdynnl closed this Aug 26, 2024
@mdynnl mdynnl deleted the legacy branch August 26, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants