feat(linux): refactor aks-secure-tls-bootstrap-client installation to use PMC/MCR#8618
Open
cameronmeissner wants to merge 20 commits into
Open
feat(linux): refactor aks-secure-tls-bootstrap-client installation to use PMC/MCR#8618cameronmeissner wants to merge 20 commits into
cameronmeissner wants to merge 20 commits into
Conversation
cameronmeissner
requested review from
AbelHu,
Devinwong,
SriHarsha001,
awesomenix,
calvin197,
djsly,
ganeshkumarashok,
lilypan26,
mxj220,
pdamianov-dev,
phealy,
r2k1,
sulixu,
surajssd,
timmy-wright and
zachary-bailey
as code owners
github-actions
Bot
added
the
components
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors how aks-secure-tls-bootstrap-client is sourced for Linux images, moving away from GitHub release tarballs toward packages.microsoft.com (PMC) for Ubuntu/Azure Linux and MCR (OCI/sysext) for Flatcar/ACL, and updates Renovate ownership for related updates.
Changes:
- Update
parts/common/components.jsonto define distro-specific sources/versions foraks-secure-tls-bootstrap-client(PMC for Ubuntu/Azure Linux, MCR sysext for Flatcar). - Update VHD build dependency caching logic to use package/sysext download helpers instead of a direct tarball download.
- Rename the “download from URL” helper in
cse_install.shfor clarity and adjust its callsite; tweak Renovate assignee/reviewer rules.
Package Update Analysis: aks-secure-tls-bootstrap-client
Version change: 1.1.2 → 1.1.3 (patch update)
OS variants affected: Ubuntu 20.04/22.04/24.04, Azure Linux 3.0, Flatcar (sysext), Windows
OS variants NOT updated: Mariner (no entry / no default fallback) — causes silent skip on Mariner builds.
Upstream changelog: Not evaluated here (not available in-repo). Manual validation recommended.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
vhdbuilder/packer/install-dependencies.sh |
Switch aks-secure-tls-bootstrap-client handling to package/sysext download flow during VHD build. |
parts/linux/cloud-init/artifacts/cse_install.sh |
Rename the custom-URL download helper and update its caller. |
parts/common/components.json |
Move component metadata to distro-specific PMC/MCR sources and bump versions. |
.github/renovate.json |
Adjust Renovate assignees/reviewers and add a rule grouping for this component. |
| rm -rf "${SECURE_TLS_BOOTSTRAP_CLIENT_DOWNLOAD_DIR}" & | ||
| if isFlatcar || isACL; then | ||
| rm -f /etc/extensions/aks-secure-tls-bootstrap-client.raw | ||
| systemd-sysext --no-reload refresh || true |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
refactor aks-secure-tls-bootstrap-client installation to use PMC/MCR now that the client is being built/published by dalec
Which issue(s) this PR fixes:
Fixes #