Add async LRO polling and OpenAPI spec sanitization#112
Open
petehauge wants to merge 4 commits into
Open
Conversation
EMaher
reviewed
Jun 6, 2026
- Implement ARM async long-running operation (LRO) polling in ApimClient for large API spec imports that exceed the 60s provisioning state timeout. Polls Azure-AsyncOperation/Location headers with a 7.5-minute deadline, honors Retry-After, and validates URLs against known ARM hosts. - Add supportsGet guard to getResource to short-circuit before network call for association resources that only support PUT/DELETE. - Add OpenAPI spec sanitizer that auto-injects missing path parameter declarations before APIM import, with warnings logged for each fix. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
e3611ff to
05627bc
Compare
…kage-build tests Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
The rebase onto main left expectedCallSequence defined but unused — main's refactored assertion uses expectedTypes with deduplication. Renamed the variable and removed the duplicate NamedValue entry that conflicts with the firstSeenInOrder filter. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
petehauge
commented
Jun 6, 2026
| /// <reference types="node" /> | ||
|
|
||
| import { execFile } from 'node:child_process'; | ||
| import { exec as execCb } from 'node:child_process'; |
Collaborator
Author
There was a problem hiding this comment.
NOTE: the fixes in this file are for running the tests on windows... Some of the packaging unit tests were failing without this...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two improvements to the APIM publish pipeline:
1. Async Long-Running Operation (LRO) Polling
Large API spec imports (e.g., 500+ paths) exceed the existing 60-second provisioning state timeout. This adds ARM async operation polling:
2. OpenAPI Spec Sanitization
APIM rejects OpenAPI specs where URL path templates reference parameters not declared in the operation's parameters array. This adds automatic sanitization:
Files Changed