Skip to content

ci(aarch64): install device-tree-compiler + fix zynqmp BSP driver bugs#11443

Draft
Copilot wants to merge 5 commits into
masterfrom
copilot/fix-aarch64-github-actions-job
Draft

ci(aarch64): install device-tree-compiler + fix zynqmp BSP driver bugs#11443
Copilot wants to merge 5 commits into
masterfrom
copilot/fix-aarch64-github-actions-job

Conversation

Copilot AI commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

The aarch64 CI job fails building zynqmp-a53-dfzu2eg because dtc is missing — zynqmp.dts never gets compiled to zynqmp.dtb, and the assembler fails on .incbin "zynqmp.dtb".

Changes

CI fix

  • .github/workflows/bsp_buildings.yml: Add apt-get install device-tree-compiler to the "Install AArch64 ToolChains" step so dtc is available during the scons pre-build phase that compiles zynqmp.dts → zynqmp.dtb.

zynqmp BSP (merged from PR #11239)

  • Full DM support: OFW, builtin FDT, GIC, SMP (4× Cortex-A53), DM-based UART/RTC drivers, PSCI
  • rtconfig.h updated to enable RT_USING_OFW, RT_USING_BUILTIN_FDT, RT_BUILTIN_FDT_PATH "zynqmp.dtb", RT_USING_DM, RT_USING_SMP, etc.
  • SConstruct calls dtc.dts_to_dtb() to generate the DTB from zynqmp.dts at build time
  • libcpu/aarch64/common/SConscript: staleness check to force rebuild of builtin_fdt_gcc.o when DTB changes

Bug fixes in xilinx_uartps.c

  • Mode register write: mode_reg & 1mode_reg — masking with 1 silently discarded all configured parity/stop/data-bit fields before writing to CDNS_UART_MR
  • Fallback clock error check: checked cdns_uart->clk instead of cdns_uart->pclk after rt_clk_get_by_name(dev, "aper_clk"), making the error path unreachable
  • Comment typo: /* Ting Indicator *//* Ring Indicator */

GuEe-GUI and others added 2 commits June 7, 2026 19:13
This is a builtin fdt example BSP

Signed-off-by: GuEe-GUI <2991707448@qq.com>
@CLAassistant

CLAassistant commented Jun 8, 2026

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ GuEe-GUI
❌ Copilot
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:copilot/fix-aarch64-github-actions-job
  • 设置PR number为 \ Set the PR number to:11443
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 copilot/fix-aarch64-github-actions-job 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the copilot/fix-aarch64-github-actions-job branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

Copilot AI changed the title [WIP] Fix failing GitHub Actions job aarch64 ci(aarch64): install device-tree-compiler + fix zynqmp BSP driver bugs Jun 8, 2026
Copilot finished work on behalf of Rbb666 June 8, 2026 01:42
Copilot AI requested a review from Rbb666 June 8, 2026 01:42
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown

📌 Code Review Assignment

🏷️ Tag: components

Reviewers: @Maihuanyi

Changed Files (Click to expand)
  • components/drivers/include/dt-bindings/interrupt-controller/arm-gic.h
  • components/drivers/include/dt-bindings/interrupt-controller/irq.h

🏷️ Tag: kernel

Reviewers: @GorrayLi @ReviewSun @hamburger-os @lianux-mm @wdfk-prog @xu18838022837

Changed Files (Click to expand)
  • src/utest/smp/smp_interrupt_pri_tc.c

🏷️ Tag: workflow

Reviewers: @Rbb666 @kurisaW @supperthomas

Changed Files (Click to expand)
  • .github/ALL_BSP_COMPILE.json
  • .github/workflows/bsp_buildings.yml
  • .github/workflows/utest_auto_run.yml

📊 Current Review Status (Last Updated: 2026-06-08 09:49 CST)


📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

@github-actions github-actions Bot added BSP Kernel PR has src relate code action github action yml imporve Arch: ARM/AArch64 BSP related with arm libcpu Component component: drivers labels Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

action github action yml imporve Arch: ARM/AArch64 BSP related with arm BSP component: drivers Component Kernel PR has src relate code libcpu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants