ci: Avoid pre-release numpy in torch nightly job#724
Merged
Conversation
Bare --upgrade plus --index-url re-resolved every dependency against the pre-release-only nightly channel, pulling in a pre-release numpy. Scope the upgrade to torch/torchvision and use --extra-index-url so numpy stays on its release version. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The torch nightly install step used
--pre --upgrade torch torchvision --index-url <nightly>.--index-urlreplaced PyPI with the pre-release-only nightly channel and--upgradere-resolved every dependency, so numpy was pulled in as a pre-release.Now the upgrade is scoped to torch/torchvision (
-P torch -P torchvision) and--extra-index-urlkeeps PyPI reachable, so numpy stays on its release version.This is the nightly failure seen in #721.
🤖 Generated with Claude Code