fix(plugins): restore the PluginQueryResult init removed by the columnMeta change#1602
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every registry plugin built before June 4 fails to load on app 0.49.0 with "Invalid plugin bundle: Bundle failed to load executable". The underlying dyld error is:
Commit 94ec469 (#1582) added
columnMeta: [PluginColumnInfo]? = nilas a parameter to the existingPluginQueryResultinit. A defaulted parameter replaces the init's mangled symbol rather than adding a new one, so PluginKit in 0.49.0 stopped exporting the init that every shipped plugin binary links against. The PluginKit ABI Gate flagged this on #1582 (3 failing runs); the PR merged over the red check with no label and no version bump.Fix
Restore the 7-parameter init as an explicit overload that delegates to the full init with
columnMeta: nil, marked@_disfavoredOverloadso source-level calls keep resolving to the full init while old binaries get their symbol back. Verified the rebuilt module exports both mangled symbols and the restored one is byte-identical to the symbol old plugins reference.This is an additive ABI change (a symbol returns); no PluginKit version bump. The
abi-additivelabel applies once the gate reports the diff.Also
Interim state
The 11 registry plugins were already rebuilt against the new ABI today, so the registry works with 0.49.0 once CDN caches refresh. This fix makes the next app release also load any plugin binary from before June 4 (including kit-17 binaries and user-side caches).