feat(sambanova): add MiniMax-M3, drop M2.5#2418
Open
octo-patch wants to merge 1 commit into
Open
Conversation
- Add `sambanova/MiniMax-M3` (192k context) to `MAX_TOKENS`, placed above M2.7 so it shows up as the recommended SambaNova model. - Remove `sambanova/MiniMax-M2.5` from `MAX_TOKENS`; M2.5 is superseded by M2.7/M3 and the listing was getting stale. - Update the SambaNova snippet in `changing_a_model.md` to use M3 as the primary model with M2.7 as the fallback. - Switch the SambaNova key-forwarding unit test to `sambanova/MiniMax-M3` so the test exercises the recommended model id.
Contributor
Review Summary by QodoUpgrade SambaNova MiniMax lineup to M3 with M2.7 fallback
WalkthroughsDescription• Add sambanova/MiniMax-M3 model with 192k context to MAX_TOKENS • Remove superseded sambanova/MiniMax-M2.5 from model registry • Update documentation to recommend M3 as primary model • Update test to use M3 for key-forwarding verification Diagramflowchart LR
A["SambaNova Model Registry"] -->|Add M3| B["MiniMax-M3 192k"]
A -->|Remove M2.5| C["MiniMax-M2.5 removed"]
A -->|Keep M2.7| D["MiniMax-M2.7 192k"]
E["Documentation"] -->|Update example| F["M3 primary, M2.7 fallback"]
G["Unit Test"] -->|Update model id| H["test_sambanova_key_forwarded"]
File Changes1. pr_agent/algo/__init__.py
|
Contributor
Code Review by Qodo
1. Removed model breaks configs
|
| 'groq/llama-3.1-8b-instant': 128000, | ||
| 'sambanova/MiniMax-M3': 192000, | ||
| 'sambanova/MiniMax-M2.7': 192000, | ||
| 'sambanova/MiniMax-M2.5': 160000, |
Contributor
There was a problem hiding this comment.
1. Removed model breaks configs 🐞 Bug ☼ Reliability
By deleting sambanova/MiniMax-M2.5 from MAX_TOKENS, any existing deployment still configured with that model id will now raise an exception at runtime when token budgeting calls get_max_tokens(). The default custom_model_max_tokens is non-positive, so there is no fallback path and the agent fails fast.
Agent Prompt
## Issue description
`MAX_TOKENS` no longer contains `sambanova/MiniMax-M2.5`, but the codebase treats missing models as a hard error. This creates a breaking change for any user config that still references the removed model id (either as `config.model` or in `fallback_models`).
## Issue Context
`get_max_tokens(model)` raises if the model is not in `MAX_TOKENS` and `config.custom_model_max_tokens` is not positive. The default configuration sets `custom_model_max_tokens=-1`, so most users will hit the exception path.
## Fix Focus Areas
Choose one of these approaches:
- Re-add `sambanova/MiniMax-M2.5` into `MAX_TOKENS` (optionally comment as deprecated), so existing configs continue to work.
- Or add an alias/migration in `get_max_tokens()` (and any other model-normalization code) that maps `sambanova/MiniMax-M2.5` -> `sambanova/MiniMax-M2.7` (or keeps the old 160k cap) while preserving new recommended defaults.
References:
- pr_agent/algo/__init__.py[226-233]
- pr_agent/algo/utils.py[992-1013]
- pr_agent/settings/configuration.toml[30-35]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refresh the SambaNova MiniMax lineup so the listed defaults match what people are currently picking.
sambanova/MiniMax-M3toMAX_TOKENSwith a 192k context (same conservative cap we already use for M2.7), placed right above the M2.7 entry so it's the first SambaNova MiniMax option in the list.sambanova/MiniMax-M2.5— it has been superseded by M2.7 / M3 and was just noise in the model list.sambanova/MiniMax-M2.7as a fallback option for anyone who still wants the older model.docs/docs/usage-guide/changing_a_model.mdto use M3 as the primary model and M2.7 as the fallback in thefallback_modelsexample.test_litellm_api_key_guard.pyto usesambanova/MiniMax-M3so the test exercises the model id we now recommend. The test still verifies the same key-forwarding behavior.Notes
Test plan
pr_agent/algo/__init__.pyparses cleanly andMAX_TOKENScontains bothsambanova/MiniMax-M3andsambanova/MiniMax-M2.7, withM2.5removed.pytest tests/unittest/test_litellm_api_key_guard.py::TestApiKeyGuard::test_sambanova_key_forwarded_for_non_ollama_model(CI to run; the test only swapped a model id string).