fix(pixels): initialise all members of strands array#927
Open
tyeth wants to merge 4 commits into
Open
Conversation
Member
Author
|
I'll test with protomq against v1 protos and send a write without an add. Should crash on released firmware and not on this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #926
Previously the strands array was only initialising the first member with the supplied initialiser (and the remainder zero initialised rather than using the supplied values):
This meant the safety check of getStrandIndex(atoi(pin)) did a check on the first element and was fine, but would presumably crash because the pins being checked were not -1 when iterating over further strands array elements, allowing the write to proceed on an unsetup PWM channel.
Change is to do the default intialising of all members in a new constructor.