GH-49907: [Python] FixedShapeTensor to_pandas_dtype returns NotImplementedError#50107
Draft
aboderinsamuel wants to merge 1 commit into
Draft
GH-49907: [Python] FixedShapeTensor to_pandas_dtype returns NotImplementedError#50107aboderinsamuel wants to merge 1 commit into
aboderinsamuel wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds a new pandas-marked unit test intended to exercise ExtensionType.to_pandas_dtype() for fixed_shape_tensor types.
Changes:
- Introduces
test_extension_type_to_pandas_dtypeunder thepandastest marker. - Calls
to_pandas_dtype()on afixed_shape_tensor(float32, [2, 2])instance.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+55
to
+57
| @pytest.mark.pandas | ||
| def test_extension_type_to_pandas_dtype(): | ||
| pa.fixed_shape_tensor(pa.float32(),[2,2]).to_pandas_dtype() |
|
|
||
| @pytest.mark.pandas | ||
| def test_extension_type_to_pandas_dtype(): | ||
| pa.fixed_shape_tensor(pa.float32(),[2,2]).to_pandas_dtype() |
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
method needs to be implemented in order to use table.to_pandas(split_blocks=True)
What changes are included in this PR?
Added to_pandas_dtype method to an extension array
Are these changes tested?
Yes
Are there any user-facing changes?
The users of Arrow would see the changes, so we would be able to use pandas on the extension arrays
FixedShapedTensorto_pandas_dtypeis returningNotImplementedError#49907