Cockpit examples: local-dev runtime + validator cleanup#588
Open
blove wants to merge 10 commits into
Open
Conversation
Fixes the serve/deploy gaps found in the wiring audit (metadata is symmetric; tooling isn't): local runtime resolution never points the iframe at localhost (env var never set ''), stale 8123 backend port, serve-example mis-launches ag-ui as langgraph dev, serve-target asymmetry, and validator coverage gaps (registry<->ports parity, smoke omits chat+render, dead fallback code). Scoped to local-dev + serve ergonomics + validators only. ag-ui production is owned by PR #580 (Railway); this lands after #580 and rebases onto it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
8 tasks: rebase onto post-#580 main, registry-derived backendCommand + local runtime env in serve-example (TDD), serve-* targets -> aliases, registry<->ports parity assertion, per-product smoke coverage + chat/render reps, remove dead wiring-spec fallback, manual local-serve acceptance. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…r serve-example Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ntime env, drops 8123 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…source of truth) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…nder reps Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…listed projects have them Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
… spec All caps are now in cockpit/ports.mjs so the try/catch fallback and parseNumberProperty helper are dead code; call portsFor directly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the serve/deploy wiring gaps found in an audit (the capability metadata was symmetric; the tooling wasn't). Scoped to local-dev + validators only — ag-ui production is owned by the already-merged #580 (Railway) and is untouched here.
serve-example.tsinjectsNEXT_PUBLIC_COCKPIT_RUNTIME_BASE_URL=''into the cockpit child so the Run-tab iframe resolves tohttp://localhost:<devPort>instead of the deployed URL (thedevPortfallback was previously dead code).backendCommand(cap):uvicornfor ag-ui,langgraph dev --port <pythonPort> --no-browserotherwise. The hardcodedlanggraph dev --port 8123literal is gone.serve-*nx targets become thin aliases toserve-example.ts --capability=<id>.capability-registry.tsports matchcockpit/ports.mjs; assert the CIcockpit-smokejob represents every product and that each listed project actually has asmoketarget (this surfaced that chat/render python had no smoke targets — now added for the two reps); removed dead "cap not in registry" fallback in the wiring spec.Test plan
nx test cockpitgreen (24 files / 106 tests), incl. newserve-example.spec.ts+ registry↔ports parity + per-product smoke-coverage assertions.serve-example --capability=ag-ui-streamingverified live: launchesuvicorn --port 5321(not langgraph/8123);backendCommandoutput confirmed for langgraph/ag-ui/render reps.content-bundle.spec.ts: empty base URL →http://localhost:<devPort>) + verified end-to-end earlier (ag-ui streaming + interrupt approve/resume).assemble-examples.ts/ag-ui-proxy.ts/deployments/ag-ui-dev//deploy-ag-ui.yml).🤖 Generated with Claude Code