Skip to content

[openapi v3.1] PHP 8.2 deprecations#178

Open
WyriHaximus wants to merge 1 commit into
cebe:openapi-31from
WyriHaximus-labs:openapi-31-8.2-deprecations
Open

[openapi v3.1] PHP 8.2 deprecations#178
WyriHaximus wants to merge 1 commit into
cebe:openapi-31from
WyriHaximus-labs:openapi-31-8.2-deprecations

Conversation

@WyriHaximus

Copy link
Copy Markdown

No description provided.

@WyriHaximus WyriHaximus mentioned this pull request Jan 13, 2023
3 tasks
@rogervila

Copy link
Copy Markdown
Contributor

@cebe LGTM :)

@pieterocp

Copy link
Copy Markdown

Suggestion: We might want to add Php 8.2 to .github/workflows/php.yml to reduce the risk of regression going forward.

@WyriHaximus

Copy link
Copy Markdown
Author

@pieterocp Whoops good point, I sometimes forget not everyone automated dealing with that out of their mind 😅 . Will either update this PR or file a PR to introduce that. (But probably both.)

@DEVizzent

Copy link
Copy Markdown

@WyriHaximus As cebe seems don't manage this repository from long time ago, and I have created and published a fork of this library. So if you want to use this changes you can send the PR to https://github.com/DEVizzent/cebe-php-openapi

@WyriHaximus

Copy link
Copy Markdown
Author

@DEVizzent Sure, did you also pull in the other PR's in I have open here? Looks like you also kept the namespaces the same so it's usable as, hopefully, a temporary drop in until @cebe has time for this package again 👍

@DEVizzent

Copy link
Copy Markdown

@WyriHaximus No sorry I didn't pull them. If you want to do it it will be great, if not I will do it next weekend.

@WyriHaximus

Copy link
Copy Markdown
Author

@DEVizzent Sure will do 👍

@WyriHaximus

Copy link
Copy Markdown
Author

@DEVizzent Any plans with the clone you made? Got the PR's in there as you requested but don't seen any activity on them yet

@DEVizzent

Copy link
Copy Markdown

@WyriHaximus sorry, I didn't get any notification. I will take a look tomorrow. I use to spend time on Open Software all Thursday.

@WyriHaximus

Copy link
Copy Markdown
Author

@DEVizzent Doh yeah then it all makes sense 😂 .

@cebe

cebe commented Feb 7, 2025

Copy link
Copy Markdown
Owner

pipeline on master is currently running against php 8.1, 8.2 and 8.3, is this still relevant?

@cebe cebe added this to the 1.8.0 milestone Feb 7, 2025
@Sweetchuck

Copy link
Copy Markdown

I think this was implemented in
(Nov 14, 2024) 2ebe618

@WyriHaximus

Copy link
Copy Markdown
Author

pipeline on master is currently running against php 8.1, 8.2 and 8.3, is this still relevant?

No clue, will have a look some time this weekend.

I think this was implemented in (Nov 14, 2024) 2ebe618

Huh? That change is about yaml, the code in this PR is PHP

@Sweetchuck

Copy link
Copy Markdown

Yes, that is true, but the PHP code changed earlier.
I haven't check if all the modifications from this PR are already in the master or not. I just check some of them.

https://github.com/cebe/php-openapi/blob/master/src/spec/Paths.php#L186

@cebe cebe removed this from the 1.8.0 milestone May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants