Skip to content

Fixes PHP 8.4 deprecation warnings#217

Open
freost wants to merge 1 commit into
cebe:masterfrom
freost:php-8.4-compatibility
Open

Fixes PHP 8.4 deprecation warnings#217
freost wants to merge 1 commit into
cebe:masterfrom
freost:php-8.4-compatibility

Conversation

@freost

@freost freost commented Nov 22, 2024

Copy link
Copy Markdown

Fixes the "Implicitly marking parameter ... as nullable is deprecated" deprecation warnings

Fixes the "Implicitly marking parameter $context as nullable is deprecated" deprecation
@freost freost changed the title Fix PHP 8.4 deprecation Fix PHP 8.4 deprecation warnings Nov 22, 2024
@freost freost changed the title Fix PHP 8.4 deprecation warnings Fixes PHP 8.4 deprecation warnings Nov 22, 2024
@tacman

tacman commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Any downsides will accepting this PR and publishing a new version?

@nadar

nadar commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

PHP 8.4 adoption is growing, so it would be nice to have support for it, @cebe . I obviously have the same issue with PHP 8.5 as well.

@nadar

nadar commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Maybe if you don’t have time (which is totally understandable, since you’re spending your free time on open source), you could add another maintainer to help? There seems to be many open PR's and Issues.

@tacman

tacman commented Jan 8, 2026

Copy link
Copy Markdown
Contributor

Another maintainer would be better than a fork.

If B/C is an issue, what about releasing a 2.0 with only PHP 8.4+ and the latest of the libraries? A quick rector pass would also make the code more maintainable because static analysis is so much better with the later versions.

@nadar

nadar commented Jan 13, 2026

Copy link
Copy Markdown
Contributor

@cebe is there anything we could do here to help you? or to help maintain the repo? PHP 8.4 als ready the most installed version currently, see => https://packagist.org/php-statistics

@nadar

nadar commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

@tacman i have published this fork, if you need this fixed: https://github.com/nadar/cebe-php-openapi/releases/tag/1.0

replace cebe/php-openapi with nadar/cebe-php-openapi in your composer.json and adjust to version ^1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants