Skip to content

added support for @ page rule#14

Open
fabianmieller wants to merge 1 commit into
cssinjs:masterfrom
fabianmieller:master
Open

added support for @ page rule#14
fabianmieller wants to merge 1 commit into
cssinjs:masterfrom
fabianmieller:master

Conversation

@fabianmieller

@fabianmieller fabianmieller commented Aug 8, 2018

Copy link
Copy Markdown

Added support for @ page rule

if rule.type === 'page' then i added the @ page rule + the selectors.

i also added a case for type 'page'.

Results:

"@page": {
        "margin": "2cm",
},
"@page :left": {
        "margin-left": "4cm",
        "margin-right": "3cm"
},
 "@page :right": {
        "margin-left": "4cm",
        "margin-right": "3cm"
}

@fabianmieller fabianmieller changed the title added support for @page added support for @ page rule Aug 8, 2018
@HenriBeck

Copy link
Copy Markdown
Member

I don't think we will accept this PR for now because @page rules aren't supported in jss yet

@kof

kof commented Aug 12, 2018

Copy link
Copy Markdown
Member

we need to add @page support, we have an issue for that in jss repo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants