Skip to content

fix: update react-devtools runtime dependencies#36697

Open
leno23 wants to merge 1 commit into
facebook:mainfrom
leno23:codex/update-react-devtools-deps
Open

fix: update react-devtools runtime dependencies#36697
leno23 wants to merge 1 commit into
facebook:mainfrom
leno23:codex/update-react-devtools-deps

Conversation

@leno23
Copy link
Copy Markdown

@leno23 leno23 commented Jun 5, 2026

Summary

Update react-devtools runtime dependencies to avoid vulnerable Electron 23 and the old update-notifier/got dependency chain.

  • Upgrade electron from ^23.1.2 to ^28.3.3
  • Upgrade update-notifier from ^5.0.0 to ^6.0.2
  • Load update-notifier with dynamic import because v6 is ESM-only while bin.js remains CommonJS
  • Update yarn.lock accordingly

Fixes #28058.

How did you test this change?

  • git diff --check
  • node --check packages/react-devtools/bin.js

I did not run the full DevTools build locally because this sparse checkout does not have installed dependencies. The issue validation steps should be run in a full checkout with dependencies installed.

@meta-cla
Copy link
Copy Markdown

meta-cla Bot commented Jun 5, 2026

Hi @leno23!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[DevTools Bug]: react-devtools depends on vulnerable versions of electron and got

1 participant