Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions patchwork/notifications.py
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,16 @@ def delete_notifications():
'patchwork/mails/patch-change-notification.txt', context
)

# Got one case where recipient.email == "<>". That causes Django to fail with:
# File "/usr/lib/python3/dist-packages/django/core/mail/message.py", line 99, in sanitize_address
# address_parts = nm + localpart + domain
# ~~~^~~~~~~~~~~
# TypeError: can only concatenate str (not "NoneType") to str
if not recipient.email or recipient.email == "<>" or recipient.email == "":
errors.append((recipient, "Invalid recipient"))
delete_notifications()
continue

message = EmailMessage(
subject=subject,
body=content,
Expand Down
2 changes: 1 addition & 1 deletion patchwork/templates/patchwork/submission.html
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ <h2>Message</h2>
<span class="message-date">{{ submission.date }} UTC</span>
</div>
<pre class="content">
{{ submission|commentsyntax }}
{{ submission|commentsyntax }}
</pre>
</div>

Expand Down
2 changes: 1 addition & 1 deletion tools/docker/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM ghcr.io/getpatchwork/pyenv:latest
FROM ghcr.io/getpatchwork/pyenv:stable-3.2

ARG UID=1000
ARG GID=1000
Expand Down
2 changes: 1 addition & 1 deletion version.txt
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.0
3.2.1