fix: handle empty string in match_regex_list to prevent IndexError#6509
Open
wahajahmed010 wants to merge 1 commit into
Open
fix: handle empty string in match_regex_list to prevent IndexError#6509wahajahmed010 wants to merge 1 commit into
wahajahmed010 wants to merge 1 commit into
Conversation
When match_regex_list receives a pattern list containing an empty string, item_matcher[-1] raises IndexError because empty strings have no characters. This is reachable from the Celery integration when CeleryIntegration.exclude_beat_tasks contains an empty string. Fix: skip empty strings in the iteration loop before the [-1] access. Fixes: getsentry#6504 Signed-off-by: Wahaj Ahmed <wahaj.ahmed010@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When
match_regex_listreceives a pattern list containing an empty string,item_matcher[-1]raisesIndexErrorbecause empty strings have no characters. This is reachable from the Celery integration whenCeleryIntegration.exclude_beat_taskscontains an empty string.Fix: skip empty strings in the iteration loop before the
[-1]access.Issues
Reminders