[aw] Pin Daily Go Function Namer experiment to concrete Claude models#37325
Merged
Conversation
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix daily Go Function Namer workflow failure
[aw] Pin Daily Go Function Namer experiment to concrete Claude models
Jun 6, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Pins the Daily Go Function Namer workflow experiment to explicit Claude model IDs to avoid alias-driven configuration drift (e.g., unsupported effort / adaptive-thinking params), and adds a regression test to ensure the frontmatter stays deterministic.
Changes:
- Updated
.github/workflows/daily-function-namer.mdexperiment variants to concrete Claude model IDs. - Regenerated
.github/workflows/daily-function-namer.lock.ymlsoGH_AW_EXPERIMENT_SPECcarries the concrete variants at runtime. - Added
TestDailyFunctionNamerUsesConcreteClaudeModelsForExperimentto enforce exact variants and disallow aliases.
Show a summary per file
| File | Description |
|---|---|
pkg/workflow/prompts_test.go |
Adds a frontmatter-parsing regression test for concrete Claude experiment variants. |
pkg/workflow/data/action_pins.json |
Updates embedded action pins (includes removal/downgrade changes that appear unrelated to the PR’s stated goal). |
pkg/actionpins/data/action_pins.json |
Same embedded action pin updates in the actionpins package copy. |
.github/workflows/daily-function-namer.md |
Replaces agent/small-agent experiment variants with concrete Claude model IDs and updates experiment text accordingly. |
.github/workflows/daily-function-namer.lock.yml |
Regenerates compiled workflow to reflect the updated experiment variants in GH_AW_EXPERIMENT_SPEC. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 5/5 changed files
- Comments generated: 3
Comment on lines
+270
to
+281
| variants, ok := modelSize["variants"].([]any) | ||
| if !ok { | ||
| t.Fatal("Expected daily-function-namer workflow to define experiments.model_size.variants") | ||
| } | ||
| if len(variants) != 2 || variants[0] != "claude-sonnet-4-6" || variants[1] != "claude-haiku-4-5-20251001" { | ||
| t.Fatalf("Expected concrete Claude variants [claude-sonnet-4-6, claude-haiku-4-5-20251001], got %#v", variants) | ||
| } | ||
| for _, variant := range variants { | ||
| if variant == "agent" || variant == "small-agent" { | ||
| t.Fatalf("Expected concrete model variants, found alias %q", variant) | ||
| } | ||
| } |
Comment on lines
+176
to
+179
| "github/gh-aw-actions/setup@v0.76.1": { | ||
| "repo": "github/gh-aw-actions/setup", | ||
| "version": "v0.78.2", | ||
| "sha": "268bf92726cb8153337c07166f382ee46e4fd897" | ||
| }, | ||
| "github/gh-aw/actions/setup-cli@v0.78.2": { | ||
| "repo": "github/gh-aw/actions/setup-cli", | ||
| "version": "v0.78.2", | ||
| "sha": "a7d4043a8224182262356a32931099b76fd332eb" | ||
| "version": "v0.76.1", | ||
| "sha": "46d564922b082d0db93244972e8005ea6904ee5f" |
Comment on lines
+176
to
+179
| "github/gh-aw-actions/setup@v0.76.1": { | ||
| "repo": "github/gh-aw-actions/setup", | ||
| "version": "v0.78.2", | ||
| "sha": "268bf92726cb8153337c07166f382ee46e4fd897" | ||
| }, | ||
| "github/gh-aw/actions/setup-cli@v0.78.2": { | ||
| "repo": "github/gh-aw/actions/setup-cli", | ||
| "version": "v0.78.2", | ||
| "sha": "a7d4043a8224182262356a32931099b76fd332eb" | ||
| "version": "v0.76.1", | ||
| "sha": "46d564922b082d0db93244972e8005ea6904ee5f" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Daily Go Function Namer failed because the experiment alias path selected a model/config combination that sent unsupported
effort/adaptive-thinking parameters. This change removes alias ambiguity in that workflow by using explicit Claude model IDs.Workflow change (source of truth)
/home/runner/work/gh-aw/gh-aw/.github/workflows/daily-function-namer.mdto replace alias variants:agent, small-agentclaude-sonnet-4-6, claude-haiku-4-5-20251001Compiled workflow sync
/home/runner/work/gh-aw/gh-aw/.github/workflows/daily-function-namer.lock.ymlsoGH_AW_EXPERIMENT_SPECcarries the concrete model variants at runtime.Regression guard
TestDailyFunctionNamerUsesConcreteClaudeModelsForExperimentinpkg/workflow/prompts_test.go:agent,small-agent) are not present