Skip to content

fix: keep devcontainer setup running after Kiro failure #2864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wondr-wclabs wants to merge 1 commit into
base: main
Choose a base branch
from
+60 −13
Open

fix: keep devcontainer setup running after Kiro failure #2864

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 47 additions & 13 deletions .devcontainer/post-create.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,24 @@ run_command() {
fi
}

# Function to run an optional command and continue on error
run_optional_command() {
local command_to_run="$*"
local output
local exit_code

output=$(eval "$command_to_run" 2>&1) || exit_code=$?
exit_code=${exit_code:-0}

if [ $exit_code -ne 0 ]; then
echo -e "\033[0;33m[WARN] Optional command failed (Exit Code $exit_code): $command_to_run\033[0m" >&2
echo -e "\033[0;33m$output\033[0m" >&2
return $exit_code
fi

return 0
}

# Installing CLI-based AI Agents

echo -e "\n🤖 Installing Copilot CLI..."
Expand Down Expand Up @@ -70,23 +88,39 @@ cleanup_kiro_installer() {
}
trap cleanup_kiro_installer EXIT

run_command "curl -fsSL \"$KIRO_INSTALLER_URL\" -o \"$KIRO_INSTALLER_PATH\""
run_command "echo \"$KIRO_INSTALLER_SHA256 $KIRO_INSTALLER_PATH\" | sha256sum -c -"
kiro_install_ok=true

run_command "bash \"$KIRO_INSTALLER_PATH\""
run_optional_command "curl -fsSL \"$KIRO_INSTALLER_URL\" -o \"$KIRO_INSTALLER_PATH\"" || kiro_install_ok=false

kiro_binary=""
if command -v kiro-cli >/dev/null 2>&1; then
kiro_binary="kiro-cli"
elif command -v kiro >/dev/null 2>&1; then
kiro_binary="kiro"
else
echo -e "\033[0;31m[ERROR] Kiro CLI installation did not create 'kiro-cli' or 'kiro' in PATH.\033[0m" >&2
exit 1
if [ "$kiro_install_ok" = true ]; then
run_optional_command "echo \"$KIRO_INSTALLER_SHA256 $KIRO_INSTALLER_PATH\" | sha256sum -c -" || kiro_install_ok=false
fi

run_command "$kiro_binary --help > /dev/null"
echo "✅ Done"
if [ "$kiro_install_ok" = true ]; then
run_optional_command "bash \"$KIRO_INSTALLER_PATH\"" || kiro_install_ok=false
fi

if [ "$kiro_install_ok" = true ]; then
kiro_binary=""
if command -v kiro-cli >/dev/null 2>&1; then
kiro_binary="kiro-cli"
elif command -v kiro >/dev/null 2>&1; then
kiro_binary="kiro"
else
echo -e "\033[0;33m[WARN] Kiro CLI installation did not create 'kiro-cli' or 'kiro' in PATH.\033[0m" >&2
kiro_install_ok=false
fi
fi

if [ "$kiro_install_ok" = true ]; then
run_optional_command "$kiro_binary --help > /dev/null" || kiro_install_ok=false
fi

if [ "$kiro_install_ok" = true ]; then
echo "✅ Done"
else
echo -e "\033[0;33m[WARN] Skipping Kiro CLI installation; continuing devcontainer setup.\033[0m" >&2
fi

echo -e "\n🤖 Installing Kimi CLI..."
# https://code.kimi.com
Expand Down
13 changes: 13 additions & 0 deletions tests/test_agent_config_consistency.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,19 @@ def test_devcontainer_kiro_installer_uses_pinned_checksum(self):
assert "sha256sum -c -" in post_create_text
assert "KIRO_SKIP_KIRO_INSTALLER_VERIFY" not in post_create_text

def test_devcontainer_kiro_install_is_non_blocking(self):
"""Kiro install failures should not stop later devcontainer setup steps."""
post_create_text = (REPO_ROOT / ".devcontainer" / "post-create.sh").read_text(
encoding="utf-8"
)
kiro_block = post_create_text.split("Installing Kiro CLI...", 1)[1].split(
"Installing Kimi CLI...", 1
)[0]

assert "run_optional_command" in kiro_block
assert "exit 1" not in kiro_block
assert "continuing devcontainer setup" in kiro_block

# --- Tabnine CLI consistency checks ---

def test_runtime_config_includes_tabnine(self):
Expand Down