Skip to content

feat: Inject OpenAPI deprecations safely#4286

Open
Skywalkr-dev wants to merge 1 commit into
google:masterfrom
Skywalkr-dev:master
Open

feat: Inject OpenAPI deprecations safely#4286
Skywalkr-dev wants to merge 1 commit into
google:masterfrom
Skywalkr-dev:master

Conversation

@Skywalkr-dev
Copy link
Copy Markdown

@Skywalkr-dev Skywalkr-dev commented Jun 6, 2026

  • Updates: openapi.go to parse and cache the 'deprecated' flag from spec
  • Updates: metadata.go to inject generic comment tags for deprecated endpoints

Fixes : #4269

@gmlewis gmlewis changed the title metadata: inject OpenAPI deprecations safely feat: Inject OpenAPI deprecations safely Jun 6, 2026
Comment thread ; Outdated
Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, it looks like a number of useful comments were removed from metadata.go for no apparent reason. Please review and revert the comment removals from this file.

@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Jun 6, 2026
@Skywalkr-dev
Copy link
Copy Markdown
Author

Also, it looks like a number of useful comments were removed from metadata.go for no apparent reason. Please review and revert the comment removals from this file.

Sorry about that, it should look good now I hope.

Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better, but some lines were still unnecessarily deleted. If you review your changes in the GitHub user interface, you can see what needs to be fixed:

Image

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.49%. Comparing base (eb96f3d) to head (fe9369f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4286   +/-   ##
=======================================
  Coverage   97.49%   97.49%           
=======================================
  Files         192      192           
  Lines       19256    19256           
=======================================
  Hits        18774    18774           
  Misses        267      267           
  Partials      215      215           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Skywalkr-dev
Copy link
Copy Markdown
Author

Better, but some lines were still unnecessarily deleted. If you review your changes in the GitHub user interface, you can see what needs to be fixed:
Image

yup, the current commit should fix it.
thanks for the review

Copy link
Copy Markdown
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @Skywalkr-dev!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29 - @Not-Dhananjay-Mishra - @munlicode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

NeedsReview PR is awaiting a review before merging.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated code_scanning_upload field from RateLimits

2 participants