Skip to content

Fix up the container build #932

Merged
ianmcorvidae merged 1 commit into
meshtastic:masterfrom
ianmcorvidae:fixup-container
Jun 8, 2026
Merged

Fix up the container build #932
ianmcorvidae merged 1 commit into
meshtastic:masterfrom
ianmcorvidae:fixup-container

Conversation

@ianmcorvidae

Copy link
Copy Markdown
Contributor

...to use a multi-stage build, cache better, and most importantly actually keep the library in the final image (fixes #931)

The issue with not keeping the library around was almost certainly my own fault when amending the prior PR for some other changes. My bad there!

…and most importantly actually keep the library in the final image (fixes meshtastic#931)
@ianmcorvidae ianmcorvidae merged commit e216848 into meshtastic:master Jun 8, 2026
11 checks passed
@ianmcorvidae ianmcorvidae deleted the fixup-container branch June 8, 2026 20:33
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.19%. Comparing base (8f0faf5) to head (dd1df47).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #932   +/-   ##
=======================================
  Coverage   63.19%   63.19%           
=======================================
  Files          25       25           
  Lines        4521     4521           
=======================================
  Hits         2857     2857           
  Misses       1664     1664           
Flag Coverage Δ
unittests 63.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meshtastic Python Docker container does not work

1 participant