Lots of logging for chat smoke tests and enable in PR builds#320108
Draft
alexr00 wants to merge 3 commits into
Draft
Lots of logging for chat smoke tests and enable in PR builds#320108alexr00 wants to merge 3 commits into
alexr00 wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds extensive, best-effort diagnostics and step-by-step logging to the Copilot-related smoke test suites to make CI failures easier to debug directly from smoke-test-runner.log, without needing to download large log artifacts.
Changes:
- Added
dumpFailureDiagnostics(...)helper to list Playwright artifacts, capture send-button DOM state, and tail Copilot Chat extension logs on failure. - Wrapped Copilot Chat Sessions and Agents Window smoke tests with richer progress logging and failure catch blocks that call
dumpFailureDiagnostics. - Changed smoke test suite gating so Chat Sessions and Agents Window suites run for all non-web, non-remote qualities (not just official distributions).
Show a summary per file
| File | Description |
|---|---|
| test/smoke/src/utils.ts | Adds dumpFailureDiagnostics helper for failure-time artifact enumeration and log tailing. |
| test/smoke/src/main.ts | Adjusts which smoke suites run based on opts/quality (notably enabling more Copilot suites). |
| test/smoke/src/areas/chat/chatSessions.test.ts | Adds detailed logging and calls dumpFailureDiagnostics on failures in Chat Sessions tests. |
| test/smoke/src/areas/agentsWindow/agentsWindow.test.ts | Adds detailed logging, a send-button selector for diagnostics, and calls dumpFailureDiagnostics on failures in Agents Window tests. |
Copilot's findings
- Files reviewed: 4/4 changed files
- Comments generated: 2
…as already built before integration tests)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.