Skip to content

Lots of logging for chat smoke tests and enable in PR builds#320108

Draft
alexr00 wants to merge 3 commits into
mainfrom
alexr00/intermediate-donkey
Draft

Lots of logging for chat smoke tests and enable in PR builds#320108
alexr00 wants to merge 3 commits into
mainfrom
alexr00/intermediate-donkey

Conversation

@alexr00
Copy link
Copy Markdown
Member

@alexr00 alexr00 commented Jun 5, 2026

No description provided.

Copilot AI review requested due to automatic review settings June 5, 2026 14:01
@alexr00 alexr00 self-assigned this Jun 5, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds extensive, best-effort diagnostics and step-by-step logging to the Copilot-related smoke test suites to make CI failures easier to debug directly from smoke-test-runner.log, without needing to download large log artifacts.

Changes:

  • Added dumpFailureDiagnostics(...) helper to list Playwright artifacts, capture send-button DOM state, and tail Copilot Chat extension logs on failure.
  • Wrapped Copilot Chat Sessions and Agents Window smoke tests with richer progress logging and failure catch blocks that call dumpFailureDiagnostics.
  • Changed smoke test suite gating so Chat Sessions and Agents Window suites run for all non-web, non-remote qualities (not just official distributions).
Show a summary per file
File Description
test/smoke/src/utils.ts Adds dumpFailureDiagnostics helper for failure-time artifact enumeration and log tailing.
test/smoke/src/main.ts Adjusts which smoke suites run based on opts/quality (notably enabling more Copilot suites).
test/smoke/src/areas/chat/chatSessions.test.ts Adds detailed logging and calls dumpFailureDiagnostics on failures in Chat Sessions tests.
test/smoke/src/areas/agentsWindow/agentsWindow.test.ts Adds detailed logging, a send-button selector for diagnostics, and calls dumpFailureDiagnostics on failures in Agents Window tests.

Copilot's findings

  • Files reviewed: 4/4 changed files
  • Comments generated: 2

Comment thread test/smoke/src/main.ts
Comment thread test/smoke/src/utils.ts
@alexr00 alexr00 changed the title Lots of logging for chat smoke tests Lots of logging for chat smoke tests and enable in PR builds Jun 5, 2026
@alexr00 alexr00 marked this pull request as ready for review June 5, 2026 15:44
@alexr00 alexr00 marked this pull request as draft June 5, 2026 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants