Skip to content

build: share product pipeline configuration#320187

Open
dileepyavan wants to merge 3 commits into
mainfrom
DileepY/disable_TSA
Open

build: share product pipeline configuration#320187
dileepyavan wants to merge 3 commits into
mainfrom
DileepY/disable_TSA

Conversation

@dileepyavan
Copy link
Copy Markdown
Member

Summary

  • move the shared product build parameters, variables, resources, SDL configuration, and stage graph into product-build-template.yml
  • keep the regular and TSA pipeline schedules/triggers in their entry-point YAML files
  • parameterize TSA and API Scan independently so the regular build keeps API Scan without TSA
  • disable publish and release for the TSA-only scheduled pipeline

Validation

  • parsed all three YAML files with PyYAML
  • verified all 21 shared-template parameter references resolve
  • verified VS Code reports no YAML diagnostics
  • ran git diff --check
  • rebased the branch onto the latest main

Notes

The repository pre-commit hook was attempted, but its git show invocation does not quote the existing product-build optional-TSA.yml filename and therefore fails at the space. The equivalent YAML, parameter-reference, diagnostics, and whitespace checks above pass. No product pipeline was queued from this branch.

Copilot AI review requested due to automatic review settings June 5, 2026 21:27
@vs-code-engineering
Copy link
Copy Markdown
Contributor

vs-code-engineering Bot commented Jun 5, 2026

📬 CODENOTIFY

The following users are being notified based on files changed in this PR:

@lszomoru

Matched files:

  • build/azure-pipelines/product-build-TSA.yml
  • build/azure-pipelines/product-build-template.yml
  • build/azure-pipelines/product-build.yml

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the VS Code product build Azure Pipelines by extracting the shared product pipeline configuration (parameters, variables, resources, SDL config, and stage graph) into a reusable product-build-template.yml, leaving the entry-point pipelines to focus on triggers/schedules and a small set of overrides.

Changes:

  • Introduces build/azure-pipelines/product-build-template.yml containing the shared product build pipeline definition.
  • Updates product-build.yml to extend the shared template and explicitly disable TSA while keeping API Scan enabled.
  • Updates product-build optional-TSA.yml to become a schedule-only entry point that extends the shared template with TSA enabled and publish/release disabled.
Show a summary per file
File Description
build/azure-pipelines/product-build.yml Converted to a thin entry-point that extends the shared template with TSA disabled and APIScan enabled.
build/azure-pipelines/product-build-template.yml New shared template containing the consolidated parameters/variables/resources/SDL config and stages for product builds.
build/azure-pipelines/product-build optional-TSA.yml Converted to a schedule-only TSA-focused entry point extending the shared template, disabling publish/release.

Copilot's findings

  • Files reviewed: 3/3 changed files
  • Comments generated: 4

Comment thread build/azure-pipelines/product-build optional-TSA.yml Outdated
Comment thread build/azure-pipelines/product-build-TSA.yml
Comment thread build/azure-pipelines/product-build-TSA.yml
Comment thread build/azure-pipelines/product-build-template.yml
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@dileepyavan dileepyavan enabled auto-merge (squash) June 5, 2026 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants