Parse headers for native MCP discovery server launch configuration#320192
Draft
dmitrivMS wants to merge 1 commit into
Draft
Parse headers for native MCP discovery server launch configuration#320192dmitrivMS wants to merge 1 commit into
dmitrivMS wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes workspace .mcp.json HTTP server configuration by ensuring static headers are preserved when converting native MCP discovery configs into McpServerLaunch definitions, aligning behavior with .vscode/mcp.json.
Changes:
- Forward
headersfrom parsedmcpServersHTTP entries into the generated HTTP launch definition. - Add a unit test validating headers are forwarded (and omitted headers become an empty list).
Show a summary per file
| File | Description |
|---|---|
| src/vs/workbench/contrib/mcp/common/discovery/nativeMcpDiscoveryAdapters.ts | Parses and forwards HTTP headers into the generated McpServerLaunch for native/workspace .mcp.json discovery. |
| src/vs/workbench/contrib/mcp/test/common/nativeMcpDiscoveryAdapters.test.ts | Adds coverage ensuring headers are forwarded for HTTP servers and default to [] when not specified. |
Copilot's findings
- Files reviewed: 2/2 changed files
- Comments generated: 1
Comment on lines
27
to
+31
| command: string; | ||
| args?: string[]; | ||
| env?: Record<string, string>; | ||
| url?: string; | ||
| headers?: Record<string, string>; |
connor4312
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #319528
Per https://code.claude.com/docs/en/mcp