Improve builds speed#320214
Draft
alexdima wants to merge 6 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR targets faster Copilot extension CI builds by removing the emsdk setup path, deleting legacy Azure Pipeline YAMLs in the extension, and switching the Copilot build cache to a stable, computed cache key.
Changes:
- Remove emsdk setup usage by deleting
extensions/copilot/build/setup-emsdk.sh. - Delete legacy Copilot extension Azure Pipelines (
extensions/copilot/build/release.yml,extensions/copilot/build/pre-release.yml). - Update Copilot pipeline setup to use a computed cache key (
.build/packagelockhash) and extend the shared cache-key computation to include a Copilot-specific cachesalt.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/build/setup-emsdk.sh | Deleted emsdk bootstrap script previously used to install/activate emscripten. |
| extensions/copilot/build/release.yml | Deleted legacy Azure Pipeline definition for stable release. |
| extensions/copilot/build/pre-release.yml | Deleted legacy Azure Pipeline definition for scheduled pre-release. |
| build/azure-pipelines/copilot/setup-steps.yml | Switch Copilot build cache key to a computed hash file; remove emsdk setup steps. |
| build/azure-pipelines/common/computeNodeModulesCacheKey.ts | Include Copilot extension .cachesalt in the computed key inputs. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://dev.azure.com/monacotools/Monaco/_build/results?buildId=445464&view=logs&j=61096ea8-10fd-584b-0f03-7b170d825b33&t=0f0ef666-d134-41bd-bd0c-cf8b2aa3f08f&l=15
https://dev.azure.com/monacotools/Monaco/_build/results?buildId=445470&view=results
https://dev.azure.com/monacotools/Monaco/_build/results?buildId=445470&view=logs&j=61096ea8-10fd-584b-0f03-7b170d825b33&t=0891a748-3441-50a4-3e8b-7656cdf5b56b
https://dev.azure.com/monacotools/Monaco/_build/results?buildId=445473&view=results
Main problems
A. Our Copilot stage was never seeing cache hits e.g.:
B. Our stages were waiting sometimes for 8-9 minutes for the copilot vsix in the "Download Copilot VSIX" stage.
In detail