Skip to content

Joshspicer/mcp no preview candidate#320224

Open
zht5128 wants to merge 14 commits into
microsoft:mainfrom
zht5128:joshspicer/mcp-no-preview-candidate
Open

Joshspicer/mcp no preview candidate#320224
zht5128 wants to merge 14 commits into
microsoft:mainfrom
zht5128:joshspicer/mcp-no-preview-candidate

Conversation

@zht5128
Copy link
Copy Markdown

@zht5128 zht5128 commented Jun 6, 2026

No description provided.

kkbrooks and others added 14 commits June 6, 2025 18:04
We didn't trigger a 'change' after the promise resolved, so if we resolve rec.templates and rec.resources synchronously (for a server with no mcp resources) then we could end before publishing everything

Refs microsoft#250890
(Reland) fix: smoke tests for stable with editcontext enabled (microsoft#251074)
…icrosoft#251012)

onDidChangeCustomChatModes not fired when user data modes change
chat: move mcp and extension tools out of preview

Following DSB approval.
Copilot AI review requested due to automatic review settings June 6, 2026 12:27
@zht5128 zht5128 marked this pull request as draft June 6, 2026 12:27
@zht5128 zht5128 marked this pull request as ready for review June 6, 2026 12:27
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates the smoke-test automation to be version-aware (for correct editor input selectors across VS Code versions) and fixes/extends Chat tool enablement behavior, alongside a handful of smaller workbench/platform tweaks.

Changes:

  • Pass parsed product versions through smoke-test automation and use a version-based editContextEnabled switch instead of Quality checks.
  • Adjust ChatSelectedTools enablement mapping for tools inside toolsets and add a regression test.
  • Misc fixes: ensure MCP quick access publishes updates, watch prompt files folder, tweak icon label/chat CSS, streamline ext host file watcher logging, adjust signature verification conditions.

Reviewed changes

Copilot reviewed 25 out of 25 changed files in this pull request and generated 5 comments.

Show a summary per file
File Description
test/smoke/src/main.ts Thread parsed versions into smoke test options and provide stable build version info to data-loss tests.
test/smoke/src/areas/workbench/data-loss.test.ts Consume stable build version to configure automation behavior.
test/automation/src/code.ts Add version to launch options and implement editContextEnabled based on version.
test/automation/src/settings.ts Switch selectors/logic to editContextEnabled.
test/automation/src/scm.ts Switch selectors/logic to editContextEnabled.
test/automation/src/notebook.ts Switch selectors/logic to editContextEnabled.
test/automation/src/extensions.ts Switch selectors/logic to editContextEnabled.
test/automation/src/editors.ts Switch selectors/logic to editContextEnabled.
test/automation/src/editor.ts Switch selectors/logic to editContextEnabled.
test/automation/src/debug.ts Switch selectors/logic to editContextEnabled.
src/vs/workbench/contrib/mcp/browser/mcpResourceQuickAccess.ts Ensure picks publish after clearing results.
src/vs/workbench/contrib/chat/browser/chatSelectedTools.ts Allow explicit per-tool enablement to override toolset defaults.
src/vs/workbench/contrib/chat/test/browser/chatSelectedTools.test.ts Add regression test for toolset/tool enablement behavior.
src/vs/workbench/contrib/chat/common/promptSyntax/utils/promptFilesLocator.ts Start watching prompts home folder for changes.
src/vs/workbench/contrib/chat/browser/media/chat.css Override suffix styling for chat attachments.
src/vs/workbench/contrib/chat/browser/chatContentParts/chatConfirmationWidget.ts Switch configuration key for “notify window” behavior.
src/vs/workbench/contrib/chat/browser/chat.contribution.ts Adjust MCP-related setting metadata/policy flags.
src/vs/workbench/api/common/extHostFileSystemEventService.ts Remove trace/id logging path and simplify dispatch checks.
src/vs/platform/extensionManagement/node/extensionManagementService.ts Skip signature-related cleanup on linux-armhf target platform.
src/vs/editor/contrib/inlineCompletions/browser/structuredLogger.ts Change logged model URI type to URI for remote translation.
src/vs/editor/contrib/inlineCompletions/browser/model/inlineCompletionsSource.ts Pass URI into structured logs.
src/vs/editor/contrib/inlineCompletions/browser/model/changeRecorder.ts Pass URI into structured logs.
src/vs/base/browser/ui/iconLabel/iconlabel.css Use opacity instead of a fixed color for suffix/description styling.
package.json Update distro identifier.
.npmrc Update Electron ms_build_id.

Comment thread test/smoke/src/main.ts

describe(`VSCode Smoke Tests (${opts.web ? 'Web' : 'Electron'})`, () => {
if (!opts.web) { setupDataLossTests(() => opts['stable-build'] /* Do not change, deferred for a reason! */, logger); }
if (!opts.web) { setupDataLossTests(() => { return { stableCodePath: opts['stable-build'], stableCodeVersion: opts['stable-version'] } /* Do not change, deferred for a reason! */; }, logger); }
stableOptions.quality = Quality.Stable;
stableOptions.logsPath = logsPath;
stableOptions.crashesPath = crashesPath;
stableOptions.version = stableCodeVersion ?? { major: 0, minor: 0, patch: 0 };
Comment on lines +136 to +138
get editContextEnabled(): boolean {
return !(this.quality === Quality.Stable && this.version.major === 1 && this.version.minor < 101);
}
this.messageElement.append(element);

if (this._configurationService.getValue<boolean>('chat.focusWindowOnConfirmation')) {
if (this._configurationService.getValue<boolean>('chat.notifyWindowOnConfirmation')) {
Comment on lines +101 to +102
await timeout(1000); // UGLY the tools service updates its state sync but emits the event async (750ms) delay. This affects the observable that depends on the event

@microsoft-github-policy-service
Copy link
Copy Markdown
Contributor

@zht5128 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@microsoft-github-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@microsoft-github-policy-service agree company="Microsoft"
Contributor License Agreement

Contribution License Agreement

This Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
and conveys certain license rights to Microsoft Corporation and its affiliates (“Microsoft”) for Your
contributions to Microsoft open source projects. This Agreement is effective as of the latest signature
date below.

  1. Definitions.
    “Code” means the computer software code, whether in human-readable or machine-executable form,
    that is delivered by You to Microsoft under this Agreement.
    “Project” means any of the projects owned or managed by Microsoft and offered under a license
    approved by the Open Source Initiative (www.opensource.org).
    “Submit” is the act of uploading, submitting, transmitting, or distributing code or other content to any
    Project, including but not limited to communication on electronic mailing lists, source code control
    systems, and issue tracking systems that are managed by, or on behalf of, the Project for the purpose of
    discussing and improving that Project, but excluding communication that is conspicuously marked or
    otherwise designated in writing by You as “Not a Submission.”
    “Submission” means the Code and any other copyrightable material Submitted by You, including any
    associated comments and documentation.
  2. Your Submission. You must agree to the terms of this Agreement before making a Submission to any
    Project. This Agreement covers any and all Submissions that You, now or in the future (except as
    described in Section 4 below), Submit to any Project.
  3. Originality of Work. You represent that each of Your Submissions is entirely Your original work.
    Should You wish to Submit materials that are not Your original work, You may Submit them separately
    to the Project if You (a) retain all copyright and license information that was in the materials as You
    received them, (b) in the description accompanying Your Submission, include the phrase “Submission
    containing materials of a third party:” followed by the names of the third party and any licenses or other
    restrictions of which You are aware, and (c) follow any other instructions in the Project’s written
    guidelines concerning Submissions.
  4. Your Employer. References to “employer” in this Agreement include Your employer or anyone else
    for whom You are acting in making Your Submission, e.g. as a contractor, vendor, or agent. If Your
    Submission is made in the course of Your work for an employer or Your employer has intellectual
    property rights in Your Submission by contract or applicable law, You must secure permission from Your
    employer to make the Submission before signing this Agreement. In that case, the term “You” in this
    Agreement will refer to You and the employer collectively. If You change employers in the future and
    desire to Submit additional Submissions for the new employer, then You agree to sign a new Agreement
    and secure permission from the new employer before Submitting those Submissions.
  5. Licenses.
  • Copyright License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license in the
    Submission to reproduce, prepare derivative works of, publicly display, publicly perform, and distribute
    the Submission and such derivative works, and to sublicense any or all of the foregoing rights to third
    parties.
  • Patent License. You grant Microsoft, and those who receive the Submission directly or
    indirectly from Microsoft, a perpetual, worldwide, non-exclusive, royalty-free, irrevocable license under
    Your patent claims that are necessarily infringed by the Submission or the combination of the
    Submission with the Project to which it was Submitted to make, have made, use, offer to sell, sell and
    import or otherwise dispose of the Submission alone or with the Project.
  • Other Rights Reserved. Each party reserves all rights not expressly granted in this Agreement.
    No additional licenses or rights whatsoever (including, without limitation, any implied licenses) are
    granted by implication, exhaustion, estoppel or otherwise.
  1. Representations and Warranties. You represent that You are legally entitled to grant the above
    licenses. You represent that each of Your Submissions is entirely Your original work (except as You may
    have disclosed under Section 3). You represent that You have secured permission from Your employer to
    make the Submission in cases where Your Submission is made in the course of Your work for Your
    employer or Your employer has intellectual property rights in Your Submission by contract or applicable
    law. If You are signing this Agreement on behalf of Your employer, You represent and warrant that You
    have the necessary authority to bind the listed employer to the obligations contained in this Agreement.
    You are not expected to provide support for Your Submission, unless You choose to do so. UNLESS
    REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING, AND EXCEPT FOR THE WARRANTIES
    EXPRESSLY STATED IN SECTIONS 3, 4, AND 6, THE SUBMISSION PROVIDED UNDER THIS AGREEMENT IS
    PROVIDED WITHOUT WARRANTY OF ANY KIND, INCLUDING, BUT NOT LIMITED TO, ANY WARRANTY OF
    NONINFRINGEMENT, MERCHANTABILITY, OR FITNESS FOR A PARTICULAR PURPOSE.
  2. Notice to Microsoft. You agree to notify Microsoft in writing of any facts or circumstances of which
    You later become aware that would make Your representations in this Agreement inaccurate in any
    respect.
  3. Information about Submissions. You agree that contributions to Projects and information about
    contributions may be maintained indefinitely and disclosed publicly, including Your name and other
    information that You submit with Your Submission.
  4. Governing Law/Jurisdiction. This Agreement is governed by the laws of the State of Washington, and
    the parties consent to exclusive jurisdiction and venue in the federal courts sitting in King County,
    Washington, unless no federal subject matter jurisdiction exists, in which case the parties consent to
    exclusive jurisdiction and venue in the Superior Court of King County, Washington. The parties waive all
    defenses of lack of personal jurisdiction and forum non-conveniens.
  5. Entire Agreement/Assignment. This Agreement is the entire agreement between the parties, and
    supersedes any and all prior agreements, understandings or communications, written or oral, between
    the parties relating to the subject matter hereof. This Agreement may be assigned by Microsoft.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.