Joshspicer/mcp no preview candidate#320224
Conversation
…-fix Kkbrooks/iconlabel fix
We didn't trigger a 'change' after the promise resolved, so if we resolve rec.templates and rec.resources synchronously (for a server with no mcp resources) then we could end before publishing everything Refs microsoft#250890
(Reland) fix: smoke tests for stable with editcontext enabled (microsoft#251074)
…icrosoft#251012) onDidChangeCustomChatModes not fired when user data modes change
…soft#251059) * chore: update electron build * chore: bump distro
skip mandatory signature verification for linux arm (microsoft#248291)
chat: move mcp and extension tools out of preview Following DSB approval.
Applies updated naming Ref microsoft#251290
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR updates the smoke-test automation to be version-aware (for correct editor input selectors across VS Code versions) and fixes/extends Chat tool enablement behavior, alongside a handful of smaller workbench/platform tweaks.
Changes:
- Pass parsed product versions through smoke-test automation and use a version-based
editContextEnabledswitch instead ofQualitychecks. - Adjust
ChatSelectedToolsenablement mapping for tools inside toolsets and add a regression test. - Misc fixes: ensure MCP quick access publishes updates, watch prompt files folder, tweak icon label/chat CSS, streamline ext host file watcher logging, adjust signature verification conditions.
Reviewed changes
Copilot reviewed 25 out of 25 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| test/smoke/src/main.ts | Thread parsed versions into smoke test options and provide stable build version info to data-loss tests. |
| test/smoke/src/areas/workbench/data-loss.test.ts | Consume stable build version to configure automation behavior. |
| test/automation/src/code.ts | Add version to launch options and implement editContextEnabled based on version. |
| test/automation/src/settings.ts | Switch selectors/logic to editContextEnabled. |
| test/automation/src/scm.ts | Switch selectors/logic to editContextEnabled. |
| test/automation/src/notebook.ts | Switch selectors/logic to editContextEnabled. |
| test/automation/src/extensions.ts | Switch selectors/logic to editContextEnabled. |
| test/automation/src/editors.ts | Switch selectors/logic to editContextEnabled. |
| test/automation/src/editor.ts | Switch selectors/logic to editContextEnabled. |
| test/automation/src/debug.ts | Switch selectors/logic to editContextEnabled. |
| src/vs/workbench/contrib/mcp/browser/mcpResourceQuickAccess.ts | Ensure picks publish after clearing results. |
| src/vs/workbench/contrib/chat/browser/chatSelectedTools.ts | Allow explicit per-tool enablement to override toolset defaults. |
| src/vs/workbench/contrib/chat/test/browser/chatSelectedTools.test.ts | Add regression test for toolset/tool enablement behavior. |
| src/vs/workbench/contrib/chat/common/promptSyntax/utils/promptFilesLocator.ts | Start watching prompts home folder for changes. |
| src/vs/workbench/contrib/chat/browser/media/chat.css | Override suffix styling for chat attachments. |
| src/vs/workbench/contrib/chat/browser/chatContentParts/chatConfirmationWidget.ts | Switch configuration key for “notify window” behavior. |
| src/vs/workbench/contrib/chat/browser/chat.contribution.ts | Adjust MCP-related setting metadata/policy flags. |
| src/vs/workbench/api/common/extHostFileSystemEventService.ts | Remove trace/id logging path and simplify dispatch checks. |
| src/vs/platform/extensionManagement/node/extensionManagementService.ts | Skip signature-related cleanup on linux-armhf target platform. |
| src/vs/editor/contrib/inlineCompletions/browser/structuredLogger.ts | Change logged model URI type to URI for remote translation. |
| src/vs/editor/contrib/inlineCompletions/browser/model/inlineCompletionsSource.ts | Pass URI into structured logs. |
| src/vs/editor/contrib/inlineCompletions/browser/model/changeRecorder.ts | Pass URI into structured logs. |
| src/vs/base/browser/ui/iconLabel/iconlabel.css | Use opacity instead of a fixed color for suffix/description styling. |
| package.json | Update distro identifier. |
| .npmrc | Update Electron ms_build_id. |
|
|
||
| describe(`VSCode Smoke Tests (${opts.web ? 'Web' : 'Electron'})`, () => { | ||
| if (!opts.web) { setupDataLossTests(() => opts['stable-build'] /* Do not change, deferred for a reason! */, logger); } | ||
| if (!opts.web) { setupDataLossTests(() => { return { stableCodePath: opts['stable-build'], stableCodeVersion: opts['stable-version'] } /* Do not change, deferred for a reason! */; }, logger); } |
| stableOptions.quality = Quality.Stable; | ||
| stableOptions.logsPath = logsPath; | ||
| stableOptions.crashesPath = crashesPath; | ||
| stableOptions.version = stableCodeVersion ?? { major: 0, minor: 0, patch: 0 }; |
| get editContextEnabled(): boolean { | ||
| return !(this.quality === Quality.Stable && this.version.major === 1 && this.version.minor < 101); | ||
| } |
| this.messageElement.append(element); | ||
|
|
||
| if (this._configurationService.getValue<boolean>('chat.focusWindowOnConfirmation')) { | ||
| if (this._configurationService.getValue<boolean>('chat.notifyWindowOnConfirmation')) { |
| await timeout(1000); // UGLY the tools service updates its state sync but emits the event async (750ms) delay. This affects the observable that depends on the event | ||
|
|
|
@zht5128 please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
No description provided.