fix: prevent memory leak in Blob.prototype.stream() upon cancel#63772
Open
EduardF1 wants to merge 1 commit into
Open
fix: prevent memory leak in Blob.prototype.stream() upon cancel#63772EduardF1 wants to merge 1 commit into
EduardF1 wants to merge 1 commit into
Conversation
Member
|
As a rule of thumb, please do not open PRs against issues with an existing active PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #63574
Currently, calling
.cancel()on a Blob stream correctly rejects pending JS pulls but leaves the internal C++ reader wakeup callback pinned in memory. This creates a detached eternal handle spanning across the C++ and JS boundary, retaining the source ArrayBuffer perpetually.This patch surgicaly modifies the
cancellifecycle to explicitly invokereader.setWakeup(undefined). This severs the cyclic GC reference chain between the nativeNode / DataQueueand the JavaScript engine, allowing V8 to correctly garbage collect the 1MiB source buffers when the stream is aborted.Testing
Verified against the user's reproduction snippet running with
--expose-gc. After 200 stream cancellations, the RSS/arrayBuffer allocation correctly dropped from ~201.0 MiB back down to 1.0 MiB baseline.