Handle bare dict types in construct_type#3383
Open
Muhtasim-Munif-Fahim wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
This PR improves handling of “bare” dict type annotations in transform/construct logic and adds support for an Error.message field in realtime response status models, with corresponding tests.
Changes:
- Treat
dict(without type parameters) as a passthrough in_transform_recursive,_async_transform_recursive, andconstruct_type. - Add
messageto realtimeErrormodels (beta + non-beta) and validate via a new test. - Add regression tests covering bare-dict behavior in transform and model construction.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_transform.py | Adds async+sync coverage for TypedDict fields annotated as bare dict. |
| tests/test_models.py | Adds coverage for construct_type(..., type_=dict) passthrough and typed dict construction. |
| tests/lib/test_realtime_response_status.py | New test validating Error.message deserialization for beta and non-beta realtime status models. |
| src/openai/types/realtime/realtime_response_status.py | Adds optional message field to realtime Error model. |
| src/openai/types/beta/realtime/realtime_response_status.py | Adds optional message field to beta realtime Error model. |
| src/openai/_utils/_transform.py | Avoids get_args(...)[1] crash for bare dict annotations by early returning. |
| src/openai/_models.py | Avoids unpacking crash for bare dict in construct_type by early returning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
351
to
356
| if origin == dict and is_mapping(data): | ||
| items_type = get_args(stripped_type)[1] | ||
| args = get_args(stripped_type) | ||
| if len(args) < 2: | ||
| return data | ||
| items_type = args[1] | ||
| return {key: _transform_recursive(value, annotation=items_type) for key, value in data.items()} |
Comment on lines
+6
to
+7
| from openai.types.beta.realtime import RealtimeResponseStatus as BetaRealtimeResponseStatus | ||
| from openai.types.realtime import RealtimeResponseStatus as RealtimeResponseStatus |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3341.
Summary
Testing