Skip to content

Filter pulp-cli livetest to the plugin under test#1037

Merged
ggainey merged 1 commit into
pulp:mainfrom
gerrod3:filter-cli-livetest
Jun 8, 2026
Merged

Filter pulp-cli livetest to the plugin under test#1037
ggainey merged 1 commit into
pulp:mainfrom
gerrod3:filter-cli-livetest

Conversation

@gerrod3

@gerrod3 gerrod3 commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Pass PYTEST_MARK="live and (<plugin markers>)" when invoking make livetest for pulp-cli 0.40.0+, which no longer ships test_requirements.txt
  • Keeps the existing path for older pulp-cli versions that install test deps from test_requirements.txt and run filtered pytest directly

Depends on pulp/pulp-cli#1419, which adds the PYTEST_MARK variable to the pulp-cli Makefile.

Test plan

  • Regenerate CI for a plugin (e.g. pulp_container) and confirm script.sh uses the filtered livetest invocation
  • With pulp-cli < 0.40.0 checked out, CI still uses test_requirements.txt + pytest -m "<plugin>"
  • With pulp-cli 0.40.0+ checked out, CI runs make livetest PYTEST_MARK="live and pulp_container" (or equivalent for multi-plugin repos)

Made with Cursor

When pulp-cli 0.40.0+ is checked out it no longer ships
test_requirements.txt, so plugin CI fell back to make livetest and ran
the entire live suite. Pass PYTEST_MARK to livetest so only the
relevant plugin tests run, e.g. live and pulp_container.
{%- endif %}
# some pulp-cli tests use the api root envvar
export PULP_API_ROOT="$(EDITOR=cat pulp config edit 2>/dev/null | awk -F'"' '/api_root/{print $2; exit}')"
{%- set cli_plugin_markers = plugins | map(attribute='name') | join(' or ') | snake %}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ggainey ggainey merged commit dcf59eb into pulp:main Jun 8, 2026
13 checks passed
@gerrod3 gerrod3 deleted the filter-cli-livetest branch June 8, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants