Skip to content

gh-151042: venv: Pass VIRTUAL_ENV through cygpath inside fish on Windows #151043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LuNoX wants to merge 2 commits into
base: main
Choose a base branch
from
+4 −0
Open

gh-151042: venv: Pass VIRTUAL_ENV through cygpath inside fish on Windows #151043

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
31b3d74
Pass VIRTUAL_ENV through cygpath inside fish on Windows
LuNoX Jun 7, 2026
0694664
📜🤖 Added by blurb_it.
blurb-it[bot] Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Lib/venv/scripts/common/activate.fish
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,9 @@ end
deactivate nondestructive

set -gx VIRTUAL_ENV __VENV_DIR__
if string match -qr 'CYGWIN|MSYS|MINGW' (uname)
set -gx VIRTUAL_ENV (cygpath -u $VIRTUAL_ENV)
end

set -gx _OLD_VIRTUAL_PATH $PATH
set -gx PATH "$VIRTUAL_ENV/"__VENV_BIN_NAME__ $PATH
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2026-06-07-13-47-05.gh-issue-151042.NMdzF2.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fixed venv exporting mixed path styles to PATH on Windows inside fish (via Cygwin, MinGW or MSYS2)
Loading