chore: Replace ora with nanospinner

__mocks__/nanospinner.js

@@ -0,0 +1,21 @@
+function createSpinner() {
+  const spinner = {
+    start: () => spinner,
+    stop: () => spinner,
+    success: () => spinner,
+    error: () => spinner,
+    warn: () => spinner,
+    info: () => spinner,
+    clear: () => spinner,
+    render: () => spinner,
+    update: () => spinner,
+    reset: () => spinner,
+    spin: () => spinner,
+    write: () => spinner,
+    loop: () => spinner,
+    isSpinning: () => false,
+  };
+  return spinner;
+}
+
+module.exports = {createSpinner};

docs/healthChecks.md

@@ -21,7 +21,7 @@ module.exports = {
           }),
           runAutomaticFix: async ({loader}) => {
             await installBar();
-            loader.succeed();
+            loader.success();
           },
         },
       ],
@@ -116,7 +116,7 @@ This function will be used to try to fix the issue when `react-native doctor` is
 
 ```ts
 type RunAutomaticFix = (args: {
-  loader: Ora;
+  loader: Loader;
   logManualInstallation: ({
     healthcheck,
     url,
@@ -134,7 +134,7 @@ type RunAutomaticFix = (args: {
 
 ##### `loader`
 
-A reference to a [`ora`](https://www.npmjs.com/package/ora) instance which should be used to report success / failure, and progress of the fix.  The fix function should always call either `loader.succeed()` or `loader.fail()` before returning.
+A reference to a [`nanospinner`](https://www.npmjs.com/package/nanospinner) instance which should be used to report success / failure, and progress of the fix.  The fix function should always call either `loader.success()` or `loader.error()` before returning.
 
 ##### `logManualInstallation`
 
@@ -150,7 +150,7 @@ A health check that requires the user to manually go download/install something.
 
 ```ts
 async function needToInstallFoo({loader, logManualInstallation}) {
-    loader.fail();
+    loader.error();
 
     return logManualInstallation({
       healthcheck: 'Foo',
@@ -167,5 +167,5 @@ async function fixFoo({loader}) {
   await exec(`foo --install`);
   await exec(`foo --fix`);
 
-  loader.succeed();
+  loader.success();
 }

docs/init.md

@@ -78,23 +78,23 @@ module.exports = {
 
 ## Post init script loading
 
-The responsibility of showing the user progress of the "Executing post init script" goes to the implementor. In the cli, the `ora` package is used to display progress.
-For a simple usage in a custom template, `ora` can be used like this in a postInitScript :
+The responsibility of showing the user progress of the "Executing post init script" goes to the implementor. In the cli, the `nanospinner` package is used to display progress.
+For a simple usage in a custom template, `nanospinner` can be used like this in a postInitScript :
 
 ```javascript
 #!/usr/bin/env node
-const ora = require('ora');
+const {createSpinner} = require('nanospinner');
 
-const spinner = ora('Executing post init script ');
+const spinner = createSpinner('Executing post init script ');
 
 new Promise((resolve) => {
   spinner.start();
   // do something
   resolve();
 }).then(() => {
-  spinner.succeed();
+  spinner.success();
 }).catch(() => {
-  spinner.fail();
+  spinner.error();
   throw new Error('Something went wrong during the post init script execution');
 });
 ```

packages/cli-clean/src/clean.ts

@@ -235,10 +235,10 @@ export async function clean(
       spinner.start(label);
       await action()
         .then(() => {
-          spinner.succeed();
+          spinner.success();
         })
         .catch((e) => {
-          spinner.fail(`${label} » ${e}`);
+          spinner.error(`${label} » ${e}`);
         });
     }
   }

packages/cli-config-apple/package.json

@@ -13,8 +13,7 @@
     "picocolors": "^1.1.1"
   },
   "devDependencies": {
-    "@react-native-community/cli-types": "20.1.3",
-    "ora": "^5.4.1"
+    "@react-native-community/cli-types": "20.1.3"
   },
   "files": [
     "build",

packages/cli-config-apple/src/tools/installPods.ts

@@ -1,6 +1,6 @@
 import fs from 'fs';
 import execa from 'execa';
-import type {Ora} from 'ora';
+import type {Loader} from '@react-native-community/cli-tools';
 import pico from 'picocolors';
 import {
   logger,
@@ -23,7 +23,7 @@ interface RunPodInstallOptions {
   newArchEnabled?: boolean;
 }
 
-async function runPodInstall(loader: Ora, options: RunPodInstallOptions) {
+async function runPodInstall(loader: Loader, options: RunPodInstallOptions) {
   const shouldHandleRepoUpdate = options?.shouldHandleRepoUpdate || true;
   try {
     loader.start(
@@ -66,7 +66,7 @@ async function runPodInstall(loader: Ora, options: RunPodInstallOptions) {
         newArchEnabled: options?.newArchEnabled,
       });
     } else {
-      loader.fail();
+      loader.error();
       logger.error(stderr);
 
       throw new CLIError(
@@ -80,7 +80,7 @@ async function runPodInstall(loader: Ora, options: RunPodInstallOptions) {
   }
 }
 
-async function runPodUpdate(loader: Ora) {
+async function runPodUpdate(loader: Loader) {
   try {
     loader.start(
       `Updating CocoaPods repositories ${pico.dim(
@@ -91,7 +91,7 @@ async function runPodUpdate(loader: Ora) {
   } catch (error) {
     // "pod" command outputs errors to stdout (at least some of them)
     logger.log((error as any).stderr || (error as any).stdout);
-    loader.fail();
+    loader.error();
 
     throw new CLIError(
       `Failed to update CocoaPods repositories for iOS project.\nPlease try again manually: "pod repo update".\nCocoaPods documentation: ${pico.dim(
@@ -113,17 +113,17 @@ async function installCocoaPodsWithGem() {
   }
 }
 
-async function installCocoaPods(loader: Ora) {
+async function installCocoaPods(loader: Loader) {
   loader.stop();
 
   loader.start('Installing CocoaPods');
 
   try {
     await installCocoaPodsWithGem();
 
-    return loader.succeed();
+    return loader.success();
   } catch (error) {
-    loader.fail();
+    loader.error();
     logger.error((error as any).stderr);
 
     throw new CLIError(
@@ -134,7 +134,7 @@ async function installCocoaPods(loader: Ora) {
   }
 }
 
-async function installPods(loader?: Ora, options?: PodInstallOptions) {
+async function installPods(loader?: Loader, options?: PodInstallOptions) {
   loader = loader || new NoopLoader();
   try {
     if (!options?.iosFolderPath && !fs.existsSync('ios')) {

packages/cli-config-apple/src/tools/pods.ts

@@ -108,9 +108,9 @@ async function install(
       iosFolderPath,
     });
     cacheManager.set(packageJson.name, 'dependencies', currentDependenciesHash);
-    loader.succeed();
+    loader.success();
   } catch (error) {
-    loader.fail();
+    loader.error();
     throw new CLIError(
       `Something went wrong while installing CocoaPods. Please run ${pico.bold(
         'pod install',
@@ -204,9 +204,9 @@ export default async function resolvePods(
         'podfileLock',
         currentPodfileLockChecksum ?? '',
       );
-      loader.succeed();
+      loader.success();
     } catch (error) {
-      loader.fail();
+      loader.error();
       throw new CLIError(
         `Something went wrong while installing CocoaPods. Please run ${pico.bold(
           'pod install',

packages/cli-config-apple/src/tools/runBundleInstall.ts

@@ -1,14 +1,14 @@
 import execa from 'execa';
 import {CLIError, logger, link} from '@react-native-community/cli-tools';
-import type {Ora} from 'ora';
+import type {Loader} from '@react-native-community/cli-tools';
 
-async function runBundleInstall(loader: Ora) {
+async function runBundleInstall(loader: Loader) {
   try {
     loader.start('Installing Ruby Gems');
 
     await execa('bundle', ['install']);
   } catch (error) {
-    loader.fail();
+    loader.error();
     logger.error((error as any).stderr || (error as any).stdout);
     throw new CLIError(
       `Looks like your iOS environment is not properly set. Please go to ${link.docs(
@@ -19,7 +19,7 @@ async function runBundleInstall(loader: Ora) {
     );
   }
 
-  loader.succeed();
+  loader.success();
 }
 
 export default runBundleInstall;

packages/cli-doctor/package.json

@@ -18,7 +18,6 @@
     "envinfo": "^7.13.0",
     "execa": "^5.0.0",
     "node-stream-zip": "^1.9.1",
-    "ora": "^5.4.1",
     "picocolors": "^1.1.1",
     "semver": "^7.5.2",
     "wcwidth": "^1.0.1",

packages/cli-doctor/src/tools/brewInstall.ts

@@ -26,7 +26,7 @@ async function brewInstall({
       return onSuccess();
     }
 
-    return loader.succeed();
+    return loader.success();
   } catch (error) {
     if (typeof onFail === 'function') {
       return onFail();

packages/cli-doctor/src/tools/downloadAndUnzip.ts

@@ -24,7 +24,7 @@ export const downloadAndUnzip = async ({
 
   const installer = await fetchToTemp(downloadUrl);
 
-  loader.text = `Installing ${component} in "${installPath}"`;
+  loader.update(`Installing ${component} in "${installPath}"`);
   try {
     await unzip(installer, installPath);
   } finally {

packages/cli-doctor/src/tools/healthchecks/__tests__/androidSDK.test.ts

@@ -123,8 +123,8 @@ describe('androidSDK', () => {
 
   it('installs the SDK if it is missing on Windows', async () => {
     const loader = new tools.NoopLoader();
-    const loaderSucceedSpy = jest.spyOn(loader, 'succeed');
-    const loaderFailSpy = jest.spyOn(loader, 'fail');
+    const loaderSuccessSpy = jest.spyOn(loader, 'success');
+    const loaderErrorSpy = jest.spyOn(loader, 'error');
     const downloadAndUnzipSpy = jest
       .spyOn(downloadAndUnzip, 'downloadAndUnzip')
       .mockImplementation(() => Promise.resolve());
@@ -178,10 +178,10 @@ describe('androidSDK', () => {
       expect(requiredComponents.includes(call[0])).toBeTruthy();
     }
 
-    expect(loaderFailSpy).toHaveBeenCalledTimes(0);
+    expect(loaderErrorSpy).toHaveBeenCalledTimes(0);
     expect(logSpy).toHaveBeenCalledTimes(0);
 
-    expect(loaderSucceedSpy).toBeCalledWith(
+    expect(loaderSuccessSpy).toBeCalledWith(
       'Android SDK configured. You might need to restart your PC for all changes to take effect.',
     );
   });

packages/cli-doctor/src/tools/healthchecks/__tests__/androidStudio.test.ts

@@ -53,8 +53,8 @@ describe('androidStudio', () => {
 
   it('downloads and unzips Android Studio on Windows when missing', async () => {
     const loader = new NoopLoader();
-    const loaderSucceedSpy = jest.spyOn(loader, 'succeed');
-    const loaderFailSpy = jest.spyOn(loader, 'fail');
+    const loaderSuccessSpy = jest.spyOn(loader, 'success');
+    const loaderErrorSpy = jest.spyOn(loader, 'error');
     const downloadAndUnzipSpy = jest
       .spyOn(downloadAndUnzip, 'downloadAndUnzip')
       .mockImplementation(() => Promise.resolve());
@@ -65,10 +65,10 @@ describe('androidStudio', () => {
       environmentInfo,
     });
 
-    expect(loaderFailSpy).toHaveBeenCalledTimes(0);
+    expect(loaderErrorSpy).toHaveBeenCalledTimes(0);
     expect(logSpy).toHaveBeenCalledTimes(0);
     expect(downloadAndUnzipSpy).toBeCalledTimes(1);
-    expect(loaderSucceedSpy).toBeCalledWith(
+    expect(loaderSuccessSpy).toBeCalledWith(
       `Android Studio installed successfully in "${
         downloadAndUnzipSpy.mock.calls[0][0].installPath || ''
       }".`,

packages/cli-doctor/src/tools/healthchecks/__tests__/jdk.test.ts

@@ -73,8 +73,8 @@ describe('jdk', () => {
 
   it('downloads and unzips JDK on Windows when missing', async () => {
     const loader = new tools.NoopLoader();
-    const loaderSucceedSpy = jest.spyOn(loader, 'succeed');
-    const loaderFailSpy = jest.spyOn(loader, 'fail');
+    const loaderSuccessSpy = jest.spyOn(loader, 'success');
+    const loaderErrorSpy = jest.spyOn(loader, 'error');
     const downloadAndUnzipSpy = jest
       .spyOn(downloadAndUnzip, 'downloadAndUnzip')
       .mockImplementation(() => Promise.resolve());
@@ -85,10 +85,10 @@ describe('jdk', () => {
       environmentInfo,
     });
 
-    expect(loaderFailSpy).toHaveBeenCalledTimes(0);
+    expect(loaderErrorSpy).toHaveBeenCalledTimes(0);
     expect(logSpy).toHaveBeenCalledTimes(0);
     expect(downloadAndUnzipSpy).toBeCalledTimes(1);
-    expect(loaderSucceedSpy).toBeCalledWith(
+    expect(loaderSuccessSpy).toBeCalledWith(
       'JDK installed successfully. Please restart your shell to see the changes',
     );
   });

packages/cli-doctor/src/tools/healthchecks/__tests__/watchman.test.ts

@@ -82,12 +82,12 @@ describe('watchman', () => {
     });
 
     const loaderSpy = new NoopLoader();
-    const loaderSucceedSpy = jest.spyOn(loaderSpy, 'succeed');
-    const loaderFailSpy = jest.spyOn(loaderSpy, 'fail');
+    const loaderSuccessSpy = jest.spyOn(loaderSpy, 'success');
+    const loaderErrorSpy = jest.spyOn(loaderSpy, 'error');
     const brewInstallSpy = jest
       .spyOn(brewInstall, 'brewInstall')
       .mockImplementation(({loader}) => {
-        loader.succeed();
+        loader.success();
         return Promise.resolve();
       });
 
@@ -102,9 +102,9 @@ describe('watchman', () => {
       value: originalPlatform,
     });
 
-    expect(loaderFailSpy).toHaveBeenCalledTimes(0);
+    expect(loaderErrorSpy).toHaveBeenCalledTimes(0);
     expect(logSpy).toHaveBeenCalledTimes(0);
     expect(brewInstallSpy).toBeCalledTimes(1);
-    expect(loaderSucceedSpy).toBeCalledTimes(1);
+    expect(loaderSuccessSpy).toBeCalledTimes(1);
   });
 });

packages/cli-doctor/src/tools/healthchecks/adb.ts

@@ -38,7 +38,7 @@ export default {
     }
   },
   runAutomaticFix: async ({loader, logManualInstallation}) => {
-    loader.fail();
+    loader.error();
     let hash: string;
     switch (link.getOS()) {
       case 'macos':
@@ -59,7 +59,7 @@ export default {
       if (device && device.connected) {
         tryRunAdbReverse(process.env.RCT_METRO_PORT || 8081, device.deviceId);
       }
-      return loader.succeed();
+      return loader.success();
     } catch (e) {
       return logManualInstallation({
         healthcheck: 'Adb',