add us2 region for NinjaOne#58
Conversation
There was a problem hiding this comment.
LGTM — small, mechanical config change adding US2 region with appropriate version bump.
Extended reasoning...
Overview
This PR adds the US2 region to the NinjaOne plugin's region selector in plugins/NinjaOne/v1/ui.json and bumps the plugin version in metadata.json from 1.1.11 to 1.1.12. The change consists of inserting one new option (https://api.us2.ninjarmm.com / US2) into an existing radio field, alongside the required version increment.
Security risks
None. The change adds a static URL constant to a radio dropdown — no auth code, no credential handling, no parsing logic, no user input processing. The base URL is still consumed by the existing OAuth2 clientCredentials flow defined in metadata.json, which is unchanged.
Level of scrutiny
Low. This is exactly the kind of mechanical, low-risk config change that fits the approval criteria — a single new entry in a list of allowed region values, following the established pattern of the other four entries. Validation passed in CI and the PR is correctly version-bumped per repo guidelines.
Other factors
A bug-hunter Nit was raised about docs/README.md line 24 still enumerating only the original four regions; this is a real but cosmetic inconsistency (the dropdown is authoritative, so functionality is unaffected) and is captured in an inline comment for the author to address. It is not severe enough to block approval. An earlier commit (02fec4f) on this branch already corrected the URL from the PR description's us2-api.ninjarmm.com to the correct api.us2.ninjarmm.com, so the URL form is current.
🧩 Plugin PR Summary📦 Modified Plugins
📋 Results
🔍 Validation Details✅
|
📋 Summary
Adds the US2 region as a selectable option for the NinjaOne plugin. A customer whose NinjaOne instance is hosted in the US2 region was unable to connect via SquaredUp, as only US, EU, Canada, and OC regions were previously available. This PR adds the US2 API base URL (
https://us2-api.ninjarmm.com) to the region selector.🔗 Related issue(s)
🧩 Plugin details
Does this PR introduce any breaking changes?
📚 Documentation
✅ Checklist