feat: re-add simplify= to print.compare.loo (#366)#369
Open
LeonidasZhak wants to merge 2 commits into
Open
Conversation
Add a 'simplify' parameter (default TRUE) to print.compare.loo(). When simplify=FALSE, the full comparison table is printed including pointwise ELPD, LOOIC/WAIC, and their standard errors for each model. This restores functionality that was available in previous versions of loo, where users could see the complete model comparison output. Changes: - R/loo_compare.R: Add simplify parameter with documentation - man/loo_compare.Rd: Regenerated by roxygen2 - man/loo-package.Rd: Minor roxygen2 update
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
==========================================
- Coverage 92.70% 92.49% -0.22%
==========================================
Files 31 31
Lines 3029 3037 +8
==========================================
+ Hits 2808 2809 +1
- Misses 221 228 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This is how benchmark results would change (along with a 95% confidence interval in relative change) if beec4b6 is merged into master:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-adds a
simplifyparameter toprint.compare.loo()(defaultTRUE), addressing #366.When
simplify = FALSE, the full comparison table is printed including pointwise ELPD, LOOIC/WAIC, and their standard errors for each model. This restores functionality that was available in previous versions of loo.Changes
R/loo_compare.R: Addsimplifyparameter toprint.compare.loo()with roxygen documentationman/loo_compare.Rd: Regenerated by roxygen2man/loo-package.Rd: Minor roxygen2 updateExample
Testing
[ FAIL 0 | WARN 0 | SKIP 2 | PASS 1144 ]simplify = TRUE(default) produces identical output to current behaviorsimplify = FALSEcorrectly displays all available estimate columnsCloses #366