fix: correct private member name _sek to _sep in random/streams/chi#12569
Draft
Planeshifter wants to merge 1 commit into
Draft
fix: correct private member name _sek to _sep in random/streams/chi#12569Planeshifter wants to merge 1 commit into
_sek to _sep in random/streams/chi#12569Planeshifter wants to merge 1 commit into
Conversation
The private member documented as the "Data separator" was named `_sek` in the declaration, but the implementation defines and uses `_sep` (`setNonEnumerableReadOnly( this, '_sep', opts.sep )` and `string2buffer( this._sep+r )`). Correct the typo so the declaration matches the implementation.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request:
random/streams/chiTypeScript declaration.The member documented as the "Data separator" was named
_sek:but the implementation defines and uses
_sep:This corrects
_sekto_sepso the declaration matches the implementation.Related Issues
No.
Questions
No.
Other
Identified during a TypeScript-declaration audit of the
@stdlib/randomnamespace and verified againstlib/main.js. The same typo exists inrandom/streams/tand is addressed in a separate PR.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
A TypeScript-declaration audit surfaced this issue using Claude Code; the finding was independently verified against the implementation (
lib/main.js) and reviewed by myself before submitting.@stdlib-js/reviewers