feat: add blas/ext/base/caxpby#12639
Open
anandkaranubc wants to merge 1 commit into
Open
Conversation
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
- task: lint_filenames
status: passed
- task: lint_editorconfig
status: passed
- task: lint_markdown_pkg_readmes
status: passed
- task: lint_markdown_docs
status: na
- task: lint_markdown
status: na
- task: lint_package_json
status: passed
- task: lint_repl_help
status: passed
- task: lint_javascript_src
status: passed
- task: lint_javascript_cli
status: na
- task: lint_javascript_examples
status: passed
- task: lint_javascript_tests
status: passed
- task: lint_javascript_benchmarks
status: passed
- task: lint_python
status: na
- task: lint_r
status: na
- task: lint_c_src
status: passed
- task: lint_c_examples
status: passed
- task: lint_c_benchmarks
status: passed
- task: lint_c_tests_fixtures
status: na
- task: lint_shell
status: na
- task: lint_typescript_declarations
status: passed
- task: lint_typescript_tests
status: passed
- task: lint_license_headers
status: passed
---
stdlib-bot
added
BLAS
anandkaranubc
commented
Jun 6, 2026
| for ( i = 0; i < m; i++ ) { | ||
| yr = yview[ iy ]; | ||
| yi = yview[ iy+1 ]; | ||
| muladd( are, aim, xview[ ix ], xview[ ix+1 ], f32( f32( bre*yr ) - f32( bim*yi ) ), f32( f32( bre*yi ) + f32( bim*yr ) ), yview, 1, iy ); |
Contributor
Author
There was a problem hiding this comment.
Using (a+bi)(c+di) = (ac - bd) + (ad + bc)i
Member
There was a problem hiding this comment.
Rather than reinvent the wheel, why not do
- https://github.com/stdlib-js/stdlib/tree/develop/lib/node_modules/%40stdlib/complex/float32/base/mul#mulassign-re1-im1-re2-im2-out-strideout-offsetout- on
y - then call
muladdwithare,aim,xview[ix],xview[ ix+1 ],yview[ iy ],yview[ iy+1 ]
Meaning, update y in-place first. Then do the muladd.
I doubt that perf will be much affected.
anandkaranubc
commented
Jun 6, 2026
anandkaranubc
added
Feature
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
reviewed
Jun 6, 2026
Member
kgryte
left a comment
kgryte
left a comment
There was a problem hiding this comment.
Other than the suggestion for the JavaScript implementation, this is looking good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves stdlib-js/metr-issue-tracker#707
Description
This pull request:
blas/ext/base/caxpbyRelated Issues
This pull request has the following related issues:
blas/ext/base/caxpbymetr-issue-tracker#707Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
Used Cursor+VS Code code-generation tools to help assist with the feature.
@stdlib-js/reviewers