style: follow-up fixes for commits merged 2026-06-05 / 2026-06-06#12641
Draft
Planeshifter wants to merge 3 commits into
Draft
style: follow-up fixes for commits merged 2026-06-05 / 2026-06-06#12641Planeshifter wants to merge 3 commits into
Planeshifter wants to merge 3 commits into
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-06-05 14:02 PDT (813f930e) and 2026-06-06 04:44 PDT (f3b8c813). A 24-hour review window flagged three small, in-scope deviations from established conventions across two new packages.This pull request:
<section class="intro"></section>placeholder toblas/ext/base/gediff/README.md, overlooked in545cf3d; aligns the file with the structure required by all sibling packages in the family.blas/ext/base/gsome(introduced in813f930): correctskJSDoc type from{PositiveInteger}to{integer}acrosslib/main.js,lib/ndarray.js, andlib/accessors.js(sincek <= 0is a valid short-circuit input), updatesstrideXdescription tostride length for `x`to matchgcusomeconvention, and switches bothbenchmark/benchmark.jsandbenchmark/benchmark.ndarray.jstorequire( '@stdlib/assert/is-boolean' ).isPrimitive.array/trues/test/test.jstoNaN, true, false, nullto match the convention established byarray/zeros,array/ones, andarray/falses; the original ordering (NaN, false, true, null) introduced inf8df9c7was inconsistent.Related Issues
This pull request has no related issues.
Questions
No.
Other
Validation
gediff→gcusum;gsome→gcusome;trues→falses/zeros/ones).4e898755,95016b8c,727a69cb,853c4b4f,3116666b) were validated and left untouched.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code under my supervision: it audited the last 24 hours of merges to
developagainst the stdlib style guides and sibling reference packages, applied the validated fixes, and drafted the description. I reviewed each change before pushing.@stdlib-js/reviewers
Generated by Claude Code