Deprecate bundled MockServer module in favour of the MockServer-maintained module#11833
Open
jamesdbloom wants to merge 2 commits into
Open
Deprecate bundled MockServer module in favour of the MockServer-maintained module#11833jamesdbloom wants to merge 2 commits into
jamesdbloom wants to merge 2 commits into
Conversation
…ained module The bundled module has no configuration helpers and defaults to a retired image. MockServer now publishes and maintains its own Testcontainers module, org.mock-server:mockserver-testcontainers (org.mockserver.testcontainers.MockServerContainer), which derives the image tag from the client library so container and client stay in version lockstep and adds DNS, transparent-proxy, HTTP/3, initialization-JSON, log-level and arbitrary-property helpers plus direct MockServerClient wiring. This deprecates the bundled classes with a Javadoc pointer to the maintained module, and adds a note to the module docs recommending it for new projects. Signed-off-by: James D Bloom <733179+jamesdbloom@users.noreply.github.com>
…erver-7.0.0 The default image was the retired jamesdbloom/mockserver:mockserver-5.5.4. Point it at the current mockserver/mockserver:mockserver-7.0.0. assertCompatibleWith already accepts both jamesdbloom/mockserver and mockserver/mockserver, so existing callers are unaffected. Signed-off-by: James D Bloom <733179+jamesdbloom@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bundled
org.testcontainers.mockserver.MockServerContainerships a single TCP port,defaults to the retired
jamesdbloom/mockserver:mockserver-5.5.4image, and has noconfiguration helpers.
MockServer now publishes and maintains its own Testcontainers module,
org.mock-server:mockserver-testcontainers(org.mockserver.testcontainers.MockServerContainer),which derives the image tag from the client library so container and client stay in version
lockstep, exposes DNS, transparent-proxy (NET_ADMIN), HTTP/3, initialization-JSON, log-level and
arbitrary-property helpers, and provides direct
MockServerClientwiring viagetClient().This PR deprecates the bundled class with a Javadoc pointer to the MockServer-maintained module so
existing users are guided to the supported option, and (separate commit) refreshes the stale default
image. Maintained by the MockServer project (github.com/mock-server).