url: fix URLSearchParams(null) per spec#63782
Open
marcopiraccini wants to merge 1 commit into
Open
Conversation
Collaborator
|
Review requested:
|
Signed-off-by: marcopiraccini <marco.piraccini@gmail.com>
12a1e52 to
2919266
Compare
Renegade334
approved these changes
Jun 7, 2026
Collaborator
gurgunday
approved these changes
Jun 7, 2026
watilde
approved these changes
Jun 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
url: fix URLSearchParams(null) to produce "null=" per spec
Per the WHATWG URL spec, the
URLSearchParamsconstructor accepts a(sequence<sequence<USVString>> or record<USVString, USVString> or USVString)union.nullis not a sequence or record, so WebIDL union resolution falls through toUSVString, whereToString(null)is"null".Here we short-circuited on
init == null, treatingnullthe same asundefinedand producing an empty string.Before:
After (matches Chrome and Deno):
Fixes: #63559