Skip to content

url: fix URLSearchParams(null) per spec #63782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcopiraccini wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −3
Open

url: fix URLSearchParams(null) per spec #63782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/internal/url.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -337,9 +337,9 @@ class URLSearchParams {
constructor(init = undefined) {
markTransferMode(this, false, false);

if (init == null) {
if (init === undefined) {
// Do nothing
} else if (typeof init === 'object' || typeof init === 'function') {
} else if (init !== null && (typeof init === 'object' || typeof init === 'function')) {
const method = init[SymbolIterator];
if (method === this[SymbolIterator] && #searchParams in init) {
// While the spec does not have this branch, we can use it as a
Expand Down
8 changes: 7 additions & 1 deletion test/parallel/test-whatwg-url-custom-searchparams-constructor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,8 +28,14 @@ function makeIterableFunc(array) {
let params;
params = new URLSearchParams(undefined);
assert.strictEqual(params.toString(), '');
// Per WebIDL union resolution, null is coerced to the USVString "null".
// Refs: https://url.spec.whatwg.org/#interface-urlsearchparams
params = new URLSearchParams(null);
assert.strictEqual(params.toString(), '');
assert.strictEqual(params.toString(), 'null=');
params = new URLSearchParams(false);
assert.strictEqual(params.toString(), 'false=');
params = new URLSearchParams(0);
assert.strictEqual(params.toString(), '0=');
params = new URLSearchParams(
makeIterableFunc([['key', 'val'], ['key2', 'val2']])
);
Expand Down
Loading